Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 372813003: Show zoom bubble for everything but an empty host. (Closed)

Created:
6 years, 5 months ago by wjmaclean
Modified:
6 years, 5 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Show zoom bubble for everything but an empty host. Changes committed in r281468 were overly restrictive about when the zoom bubble can be shown. This CL restores the old behaviour, noting that the usual cases where the zoom bubble is supressed, namely for changes initiated from the wrench menu and for changes in the dev tools window, are done elsewhere in the browser. BUG=391680 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282073

Patch Set 1 #

Patch Set 2 : Rebase to r282005 #

Patch Set 3 : Fix test expectation. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -21 lines) Patch
M chrome/browser/ui/zoom/zoom_controller.h View 1 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/ui/zoom/zoom_controller.cc View 1 2 chunks +5 lines, -14 lines 0 comments Download
M chrome/browser/ui/zoom/zoom_controller_unittest.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
wjmaclean
This is a small change, can you please take a look?
6 years, 5 months ago (2014-07-08 12:37:43 UTC) #1
Dan Beam
lgtm
6 years, 5 months ago (2014-07-08 20:39:24 UTC) #2
wjmaclean
The CQ bit was checked by wjmaclean@chromium.org
6 years, 5 months ago (2014-07-08 20:47:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wjmaclean@chromium.org/372813003/1
6 years, 5 months ago (2014-07-08 20:49:51 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium ...
6 years, 5 months ago (2014-07-08 21:33:45 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-08 21:36:06 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_aosp on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/90888) ios_rel_device_ninja on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/builds/26980) linux_chromium_gn_rel ...
6 years, 5 months ago (2014-07-08 21:36:07 UTC) #7
wjmaclean
The CQ bit was checked by wjmaclean@chromium.org
6 years, 5 months ago (2014-07-09 11:10:11 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wjmaclean@chromium.org/372813003/1
6 years, 5 months ago (2014-07-09 11:10:58 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium ...
6 years, 5 months ago (2014-07-09 11:22:55 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-09 11:24:05 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/26419)
6 years, 5 months ago (2014-07-09 11:24:06 UTC) #12
wjmaclean
The CQ bit was checked by wjmaclean@chromium.org
6 years, 5 months ago (2014-07-09 12:09:21 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wjmaclean@chromium.org/372813003/20001
6 years, 5 months ago (2014-07-09 12:11:05 UTC) #14
wjmaclean
The CQ bit was checked by wjmaclean@chromium.org
6 years, 5 months ago (2014-07-09 13:56:16 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wjmaclean@chromium.org/372813003/40001
6 years, 5 months ago (2014-07-09 13:56:57 UTC) #16
commit-bot: I haz the power
6 years, 5 months ago (2014-07-09 17:20:31 UTC) #17
Message was sent while issue was closed.
Change committed as 282073

Powered by Google App Engine
This is Rietveld 408576698