Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 372743004: ozone: Fix interactive_ui_tests build (Closed)

Created:
6 years, 5 months ago by spang
Modified:
6 years, 5 months ago
Reviewers:
sky
CC:
chromium-reviews, extensions-reviews_chromium.org, jennb, ben+aura_chromium.org, sadrul, Dmitry Titov, jianli, dcheng, kalyank, chromium-apps-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

ozone: Fix interactive_ui_tests build This fixes the build only. We need to implement the rest of UIControlsOzone to make the tests pass. BUG=362166 TEST=build interactive_ui_tests with use_ozone=1 chromeos=1 TBR=sky Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281601

Patch Set 1 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -9 lines) Patch
M build/all.gyp View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_commands_global_registry_apitest.cc View 3 chunks +3 lines, -3 lines 1 comment Download
M chrome/browser/ui/panels/base_panel_browser_test.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M ui/aura/aura.gyp View 1 chunk +1 line, -0 lines 0 comments Download
A ui/aura/test/ui_controls_factory_ozone.cc View 1 chunk +87 lines, -0 lines 1 comment Download

Messages

Total messages: 10 (0 generated)
spang
6 years, 5 months ago (2014-07-07 18:09:00 UTC) #1
spang
The CQ bit was checked by spang@chromium.org
6 years, 5 months ago (2014-07-07 18:09:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/spang@chromium.org/372743004/40001
6 years, 5 months ago (2014-07-07 18:10:37 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_chromeos_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-07 20:08:58 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-07 20:15:51 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chromeos_rel/builds/45010)
6 years, 5 months ago (2014-07-07 20:15:52 UTC) #6
spang
The CQ bit was checked by spang@chromium.org
6 years, 5 months ago (2014-07-07 21:23:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/spang@chromium.org/372743004/40001
6 years, 5 months ago (2014-07-07 21:24:25 UTC) #8
commit-bot: I haz the power
Change committed as 281601
6 years, 5 months ago (2014-07-07 23:17:44 UTC) #9
sky
6 years, 5 months ago (2014-07-09 20:17:49 UTC) #10
Message was sent while issue was closed.
https://codereview.chromium.org/372743004/diff/40001/chrome/browser/extension...
File chrome/browser/extensions/extension_commands_global_registry_apitest.cc
(right):

https://codereview.chromium.org/372743004/diff/40001/chrome/browser/extension...
chrome/browser/extensions/extension_commands_global_registry_apitest.cc:33: #if
defined(OS_LINUX) && defined(USE_X11)
Do we need the OS_LINUX conditions in the ifdefs here and other files?

https://codereview.chromium.org/372743004/diff/40001/ui/aura/test/ui_controls...
File ui/aura/test/ui_controls_factory_ozone.cc (right):

https://codereview.chromium.org/372743004/diff/40001/ui/aura/test/ui_controls...
ui/aura/test/ui_controls_factory_ozone.cc:17: UIControlsOzone(WindowTreeHost*
host) : host_(host) {}
explicit

Powered by Google App Engine
This is Rietveld 408576698