Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Issue 372713004: Wait for parent directory sync before performing server-side copy (Closed)

Created:
6 years, 5 months ago by hashimoto
Modified:
6 years, 5 months ago
Reviewers:
kinaba
CC:
chromium-reviews, nkostylev+watch_chromium.org, tzik, tfarina, nhiroki, oshima+watch_chromium.org, stevenjb+watch_chromium.org, kinuko+fileapi, davemoore+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Wait for parent directory sync before performing server-side copy Add SyncClient::WaitForUpdateTaskToComplete(). Use the new method from CoypOperation. BUG=384213 TEST=unit_tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284877

Patch Set 1 : #

Patch Set 2 : Add operation_observer.cc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+266 lines, -9 lines) Patch
M chrome/browser/chromeos/drive/file_system.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system/copy_operation.h View 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system/copy_operation.cc View 1 chunk +51 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system/copy_operation_unittest.cc View 3 chunks +93 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system/operation_observer.h View 1 3 chunks +8 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/drive/file_system/operation_observer.cc View 1 1 chunk +17 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system/operation_test_base.h View 3 chunks +14 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system/operation_test_base.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/drive/sync_client.h View 3 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/drive/sync_client.cc View 2 chunks +20 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/drive/sync_client_unittest.cc View 1 chunk +33 lines, -0 lines 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
hashimoto
Please review. Maybe we should rename OperationObserver to OperationDelegate or something more appropriate.
6 years, 5 months ago (2014-07-22 06:44:14 UTC) #1
kinaba
lgtm once the style error making bots red is fixed. OperationDelegate sgtm
6 years, 5 months ago (2014-07-22 08:23:35 UTC) #2
hashimoto
Added operation_observer.cc to suppress the clang error.
6 years, 5 months ago (2014-07-22 09:36:47 UTC) #3
hashimoto
The CQ bit was checked by hashimoto@chromium.org
6 years, 5 months ago (2014-07-23 03:06:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/372713004/40001
6 years, 5 months ago (2014-07-23 03:07:14 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-23 07:02:14 UTC) #6
Message was sent while issue was closed.
Change committed as 284877

Powered by Google App Engine
This is Rietveld 408576698