content/browser/web_contents/web_contents_android.cc - Issue 372693003: [Android] Fix smart clip callback to include URI and title

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_android.cc

Issue 372693003: [Android] Fix smart clip callback to include URI and title (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: really removed mSmartClipResultHandler Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/web_contents/web_contents_android.h ('k') | content/public/android/java/src/org/chromium/content/browser/ContentView.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/web_contents/web_contents_android.cc

diff --git a/content/browser/web_contents/web_contents_android.cc b/content/browser/web_contents/web_contents_android.cc

index fb8c0db8aa5e03644624875a4898b843b983cba0..fbb5071ac1d2fef685197b2b985f6f83d73682f7 100644

--- a/content/browser/web_contents/web_contents_android.cc

+++ b/content/browser/web_contents/web_contents_android.cc

@@ -62,6 +62,12 @@ ScopedJavaLocalRef<jstring> WebContentsAndroid::GetTitle(

web_contents_->GetTitle());

}

+ScopedJavaLocalRef<jstring> WebContentsAndroid::GetVisibleURL(

+ JNIEnv* env, jobject obj) const {

+ return base::android::ConvertUTF8ToJavaString(

+ env, web_contents_->GetVisibleURL().spec());

void WebContentsAndroid::Stop(JNIEnv* env, jobject obj) {

web_contents_->Stop();

}