Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Issue 372543002: Use [TreatNullAs=EmptyString] for HTMLInputElement.value (Closed)

Created:
6 years, 5 months ago by Jens Widell
Modified:
6 years, 5 months ago
Reviewers:
haraken
CC:
blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org, arv+blink, Inactive
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Use [TreatNullAs=EmptyString] for HTMLInputElement.value This is what the specification has. Previous behavior for setting the value IDL attribute to null was effectively to reset the form control's value to the default, which is wrong. New behavior also matches that of Firefox and Opera/Presto. BUG=391194 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177564

Patch Set 1 : add testcase #

Patch Set 2 : the fix #

Total comments: 2

Patch Set 3 : testcase style adjustment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -1 line) Patch
A LayoutTests/fast/dom/HTMLInputElement/input-value-null.html View 1 2 1 chunk +62 lines, -0 lines 0 comments Download
A LayoutTests/fast/dom/HTMLInputElement/input-value-null-expected.txt View 1 1 chunk +8 lines, -0 lines 0 comments Download
M Source/core/html/HTMLInputElement.idl View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Jens Widell
PTAL
6 years, 5 months ago (2014-07-05 09:42:09 UTC) #1
haraken
LGTM You could also mention that Firefox also aligns with the behavior in the CL ...
6 years, 5 months ago (2014-07-05 09:45:18 UTC) #2
Jens Widell
Thanks for awesomely quick review! Testcase style fixed, and description extended as suggested.
6 years, 5 months ago (2014-07-05 09:57:45 UTC) #3
Jens Widell
The CQ bit was checked by jl@opera.com
6 years, 5 months ago (2014-07-05 13:27:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jl@opera.com/372543002/40001
6 years, 5 months ago (2014-07-05 13:28:01 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_rel on tryserver.blink ...
6 years, 5 months ago (2014-07-05 14:30:43 UTC) #6
commit-bot: I haz the power
6 years, 5 months ago (2014-07-05 14:51:39 UTC) #7
Message was sent while issue was closed.
Change committed as 177564

Powered by Google App Engine
This is Rietveld 408576698