Mac: delay window raising until space transitions.

Mac: delay window raising until space transitions.

When manually raising browser windows in response to a dock activation that
triggered a space transition, isOnActiveSpace is wrong and we focus the wrong
space's windows. Detect this by seeing if the key window is off-screen. If so,
delay the raise until the space change notification.

BUG=309656
TEST=see bug

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=231647

[davidben, 2013-10-23 16:04:45]

More spaces woes.

https://codereview.chromium.org/37253004/diff/40001/chrome/browser/app_contro...
File chrome/browser/app_controller_mac.mm (right):

https://codereview.chromium.org/37253004/diff/40001/chrome/browser/app_contro...
chrome/browser/app_controller_mac.mm:1126: reopenTime_ = base::TimeTicks::Now();
Not calling FocusWindowSet here is apparently necessary. If it's called both
here and in activeSpaceDidChange, the focus gets really confused. If the omnibox
is focused, first keypress goes to the wrong window and switches space. Future
keypresses go to the right window which is now hidden and don't trigger a space
change.

[Nico, 2013-10-29 17:52:22]

lgtm

Maybe a comment in app_controller_mac.mm should contain parts of the CL
description and maybe a reference to the bug this is for.

[davidben, 2013-10-29 18:11:40]

Expanded on the comment and referenced the bug.

[commit-bot: I haz the power, 2013-10-29 18:41:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/davidben@chromium.org/37253004/220001

[commit-bot: I haz the power, 2013-10-29 21:57:57]

Change committed as 231647