Retrieve client_id from GoogleUpdateSettings when its missing from Local State.

chrome/installer/util/google_update_settings.h

Index: chrome/installer/util/google_update_settings.h
diff --git a/chrome/installer/util/google_update_settings.h b/chrome/installer/util/google_update_settings.h
index f1b27debe52c580574ac4653301dcc0d9d0f9868..397a4dd826bb59d7f0973f600f6368c88cc82b6a 100644
--- a/chrome/installer/util/google_update_settings.h
+++ b/chrome/installer/util/google_update_settings.h
@@ -86,12 +86,16 @@ class GoogleUpdateSettings {
                                             bool consented);
 #endif
 
-  // Returns the metrics client-id backed up in the registry. If none found,
-  // returns empty string.
-  static bool RetrieveMetricsID(std::string* metrics_id);
+  // Returns the metrics info backed up in the registry. Only non-null
+  // parameters will be retrieved. Returns false on retrieval failure for
+  // |metrics_id| (|installation_date| is not considered critical and is simply
+  // set to 0 on retrieval failure).
+  static bool RetrieveMetricsInfo(std::string* metrics_id,
+                                  int64* installation_date);
 
   // Saves a backup of the metrics client-id in the registry.
-  static bool SaveMetricsID(const std::string& metrics_id);
+  static bool SaveMetricsInfo(const std::string& metrics_id,
+                              const int64 installation_date);

[Ilya Sherman, 2014/07/08 01:10:22]

nit: No need for the const in front of an int parameter.

[gab, 2014/07/09 19:16:59]

Indeed, not sure how this ended up there, it's not in the impl at least :-)!

 
   // Sets the machine-wide EULA consented flag required on OEM installs.
   // Returns false if the setting could not be recorded.