Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Unified Diff: chrome/browser/google/google_update_settings_posix.cc

Issue 372473004: Retrieve client_id from GoogleUpdateSettings when its missing from Local State. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: merge Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/google/google_update_settings_posix.cc
diff --git a/chrome/browser/google/google_update_settings_posix.cc b/chrome/browser/google/google_update_settings_posix.cc
index 06b65efa145902e243730c93db53d512d73fc996..117c7d69a61057c71dd692865c7b119b068a8137 100644
--- a/chrome/browser/google/google_update_settings_posix.cc
+++ b/chrome/browser/google/google_update_settings_posix.cc
@@ -67,14 +67,19 @@ bool GoogleUpdateSettings::SetCollectStatsConsent(bool consented) {
}
// static
-bool GoogleUpdateSettings::RetrieveMetricsID(std::string* metrics_id) {
+// TODO(gab): Implement |installation_date| saving/retrieval on POSIX.
+bool GoogleUpdateSettings::RetrieveMetricsInfo(std::string* metrics_id,
+ int64* /* installation_date */) {
base::AutoLock lock(g_posix_client_id_lock.Get());
*metrics_id = g_posix_client_id.Get();
return true;
}
// static
-bool GoogleUpdateSettings::SaveMetricsID(const std::string& client_id) {
+// TODO(gab): Implement |installation_date| saving/retrieval on POSIX.
+bool GoogleUpdateSettings::SaveMetricsInfo(
+ const std::string& client_id,
+ const base::Time& /* installation_date */) {
// Make sure that user has consented to send crashes.
if (!GoogleUpdateSettings::GetCollectStatsConsent())
return false;

Powered by Google App Engine
This is Rietveld 408576698