chrome/browser/metrics/chrome_metrics_service_client.cc - Issue 372473004: Retrieve client_id from GoogleUpdateSettings when its missing from Local State.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/metrics/chrome_metrics_service_client.cc

Issue 372473004: Retrieve client_id from GoogleUpdateSettings when its missing from Local State. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: nits + git cl format Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/google/google_update_settings_posix.cc ('k') | chrome/browser/metrics/extensions_metrics_provider_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/metrics/chrome_metrics_service_client.cc

diff --git a/chrome/browser/metrics/chrome_metrics_service_client.cc b/chrome/browser/metrics/chrome_metrics_service_client.cc

index f10cc159d9b69fc06b362aad945ca0a33cf1ff8c..def8cd6a469d348623599f5574bfdfdf38987a91 100644

--- a/chrome/browser/metrics/chrome_metrics_service_client.cc

+++ b/chrome/browser/metrics/chrome_metrics_service_client.cc

@@ -35,7 +35,6 @@

#include "chrome/common/crash_keys.h"

#include "chrome/common/pref_names.h"

#include "chrome/common/render_messages.h"

-#include "chrome/installer/util/google_update_settings.h"

#include "components/metrics/metrics_service.h"

#include "components/metrics/net/net_metrics_log_uploader.h"

#include "content/public/browser/browser_thread.h"

@@ -165,9 +164,6 @@ void ChromeMetricsServiceClient::RegisterPrefs(PrefRegistrySimple* registry) {

void ChromeMetricsServiceClient::SetMetricsClientId(

const std::string& client_id) {

crash_keys::SetCrashClientIdFromGUID(client_id);

- // Store a backup of the client id in Google Update settings.

- GoogleUpdateSettings::StoreMetricsClientId(client_id);

gab 2014/07/16 15:51:43 (here)

}

bool ChromeMetricsServiceClient::IsOffTheRecordSessionActive() {