Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Side by Side Diff: chrome/browser/metrics/extensions_metrics_provider_unittest.cc

Issue 372473004: Retrieve client_id from GoogleUpdateSettings when its missing from Local State. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: nits:grt Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/metrics/extensions_metrics_provider.h" 5 #include "chrome/browser/metrics/extensions_metrics_provider.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "base/memory/scoped_ptr.h"
9 #include "base/prefs/testing_pref_service.h" 10 #include "base/prefs/testing_pref_service.h"
11 #include "components/metrics/client_info.h"
12 #include "components/metrics/metrics_service.h"
10 #include "components/metrics/metrics_state_manager.h" 13 #include "components/metrics/metrics_state_manager.h"
11 #include "components/metrics/proto/system_profile.pb.h" 14 #include "components/metrics/proto/system_profile.pb.h"
12 #include "extensions/common/extension.h" 15 #include "extensions/common/extension.h"
13 #include "extensions/common/extension_builder.h" 16 #include "extensions/common/extension_builder.h"
14 #include "extensions/common/extension_set.h" 17 #include "extensions/common/extension_set.h"
15 #include "testing/gtest/include/gtest/gtest.h" 18 #include "testing/gtest/include/gtest/gtest.h"
16 19
17 namespace { 20 namespace {
18 21
19 bool IsMetricsReportingEnabled() { 22 bool IsMetricsReportingEnabled() {
20 return true; 23 return true;
21 } 24 }
22 25
26 void StoreNoClientInfoBackup(const metrics::ClientInfo& /* client_info */) {
27 }
28
29 scoped_ptr<metrics::ClientInfo> ReturnNoBackup() {
30 return scoped_ptr<metrics::ClientInfo>();
31 }
32
23 class TestExtensionsMetricsProvider : public ExtensionsMetricsProvider { 33 class TestExtensionsMetricsProvider : public ExtensionsMetricsProvider {
24 public: 34 public:
25 explicit TestExtensionsMetricsProvider( 35 explicit TestExtensionsMetricsProvider(
26 metrics::MetricsStateManager* metrics_state_manager) 36 metrics::MetricsStateManager* metrics_state_manager)
27 : ExtensionsMetricsProvider(metrics_state_manager) {} 37 : ExtensionsMetricsProvider(metrics_state_manager) {}
28 38
29 // Makes the protected HashExtension method available to testing code. 39 // Makes the protected HashExtension method available to testing code.
30 using ExtensionsMetricsProvider::HashExtension; 40 using ExtensionsMetricsProvider::HashExtension;
31 41
32 protected: 42 protected:
(...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after
86 EXPECT_EQ(10, 96 EXPECT_EQ(10,
87 TestExtensionsMetricsProvider::HashExtension( 97 TestExtensionsMetricsProvider::HashExtension(
88 "mdhofdjgenpkhlmddfaegdjddcecipmo", 3817)); 98 "mdhofdjgenpkhlmddfaegdjddcecipmo", 3817));
89 } 99 }
90 100
91 // Checks that the fake set of extensions provided by 101 // Checks that the fake set of extensions provided by
92 // TestExtensionsMetricsProvider is encoded properly. 102 // TestExtensionsMetricsProvider is encoded properly.
93 TEST(ExtensionsMetricsProvider, SystemProtoEncoding) { 103 TEST(ExtensionsMetricsProvider, SystemProtoEncoding) {
94 metrics::SystemProfileProto system_profile; 104 metrics::SystemProfileProto system_profile;
95 TestingPrefServiceSimple local_state; 105 TestingPrefServiceSimple local_state;
96 metrics::MetricsStateManager::RegisterPrefs(local_state.registry()); 106 MetricsService::RegisterPrefs(local_state.registry());
97 scoped_ptr<metrics::MetricsStateManager> metrics_state_manager( 107 scoped_ptr<metrics::MetricsStateManager> metrics_state_manager(
98 metrics::MetricsStateManager::Create(&local_state, 108 metrics::MetricsStateManager::Create(
99 base::Bind(&IsMetricsReportingEnabled))); 109 &local_state,
110 base::Bind(&IsMetricsReportingEnabled),
111 base::Bind(&StoreNoClientInfoBackup),
112 base::Bind(&ReturnNoBackup)));
100 TestExtensionsMetricsProvider extension_metrics(metrics_state_manager.get()); 113 TestExtensionsMetricsProvider extension_metrics(metrics_state_manager.get());
101 extension_metrics.ProvideSystemProfileMetrics(&system_profile); 114 extension_metrics.ProvideSystemProfileMetrics(&system_profile);
102 ASSERT_EQ(2, system_profile.occupied_extension_bucket_size()); 115 ASSERT_EQ(2, system_profile.occupied_extension_bucket_size());
103 EXPECT_EQ(10, system_profile.occupied_extension_bucket(0)); 116 EXPECT_EQ(10, system_profile.occupied_extension_bucket(0));
104 EXPECT_EQ(1007, system_profile.occupied_extension_bucket(1)); 117 EXPECT_EQ(1007, system_profile.occupied_extension_bucket(1));
105 } 118 }
OLDNEW
« no previous file with comments | « chrome/browser/metrics/chrome_metrics_service_client.cc ('k') | chrome/browser/metrics/metrics_services_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698