Retrieve client_id from GoogleUpdateSettings when its missing from Local State.

chrome/chrome_installer_util.gypi

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'target_defaults': {
     'variables': {
       'installer_util_target': 0,
     },
     'target_conditions': [
@@ skipping 103 matching lines @@
           'variables': {
             'installer_util_target': 1,
           },
           'dependencies': [
             'installer_util_strings',
             '<(DEPTH)/base/base.gyp:base',
             '<(DEPTH)/base/third_party/dynamic_annotations/dynamic_annotations.gyp:dynamic_annotations',
             '<(DEPTH)/chrome/chrome_resources.gyp:chrome_resources',
             '<(DEPTH)/chrome/chrome_resources.gyp:chrome_strings',
             '<(DEPTH)/chrome/common_constants.gyp:common_constants',
+            '<(DEPTH)/components/components.gyp:metrics',
             '<(DEPTH)/courgette/courgette.gyp:courgette_lib',
             '<(DEPTH)/crypto/crypto.gyp:crypto',
             '<(DEPTH)/third_party/bspatch/bspatch.gyp:bspatch',
             '<(DEPTH)/third_party/icu/icu.gyp:icui18n',
             '<(DEPTH)/third_party/icu/icu.gyp:icuuc',
             '<(DEPTH)/third_party/lzma_sdk/lzma_sdk.gyp:lzma_sdk',
           ],
           'sources': [
             'installer/util/chrome_app_host_operations.cc',
             'installer/util/chrome_app_host_operations.h',
@@ skipping 43 matching lines @@
     ['OS=="win" and target_arch=="ia32"', {
       'targets': [
         {
           'target_name': 'installer_util_nacl_win64',
           'type': 'static_library',
           'variables': {
             'installer_util_target': 1,
           },
           'dependencies': [
             'installer_util_strings',
+            '<(DEPTH)/components/components.gyp:metrics',

[gab, 2014/07/16 20:36:54]

This dependency causes link errors between x86 vs x64 targets on Windows:

metrics.lib(metrics.persisted_logs.obj) : fatalerror LNK1112: module machine
type 'X86' conflicts with target machine type 'x64'

I don't really understand why (persistent_logs.cc uses base/base64.h...?!)...

The only solution I can think of is to introduce the metrics_common target as I
originally was going to do (which would only contain client_info.[cc|h] for
now).

WDYT?

[Ilya Sherman, 2014/07/16 20:40:42]

Justin, could you help us understand this error message in the 64-bit Windows
build?  (FWIW, I'm pretty sure base/base64.h is irrelevant.)

[jschuh, 2014/07/16 23:40:19]

I'm stumped. The error message means that you're grabbing a 32-bit lib in the
64-bit build. It doesn't look like you're building the 32-bit target, so maybe
you're not building the 64-bit target and end up picking up a 32-bit default?

[grt (UTC plus 2), 2014/07/18 01:14:49]

is this dependency even needed? installer_util_nacl_win64 doesn't build the
sources that would need the metrics component, does it
(google_update_settings.{cc,h})? what happens if you remove this line?

[gab, 2014/07/18 02:41:06]

It does, google_update_settings.cc is in target_defaults (i.e. all targets in
this file..)

           ],
           'include_dirs': [
             '<(SHARED_INTERMEDIATE_DIR)',
           ],
           'sources': [
             'installer/util/google_chrome_distribution_dummy.cc',
             'installer/util/master_preferences.h',
             'installer/util/master_preferences_dummy.cc',
           ],
           'configurations': {
@@ skipping 24 matching lines @@
           ],
           'include_dirs': [
             '<(DEPTH)',
           ],
         }
       ],
     }],
 
   ],
 }