OLD | NEW |
---|---|
(Empty) | |
1 // Copyright 2014 The Chromium Authors. All rights reserved. | |
2 // Use of this source code is governed by a BSD-style license that can be | |
3 // found in the LICENSE file. | |
4 | |
5 #ifndef COMPONENTS_METRICS_CLIENT_INFO_H_ | |
6 #define COMPONENTS_METRICS_CLIENT_INFO_H_ | |
7 | |
8 #include <string> | |
9 | |
10 #include "base/basictypes.h" | |
11 #include "base/macros.h" | |
12 | |
13 namespace metrics { | |
14 | |
15 // A data object used to pass data from outside the metrics component into the | |
16 // metrics component. | |
17 struct ClientInfo { | |
18 public: | |
Ilya Sherman
2014/07/11 04:45:41
nit: Structs are public by default.
gab
2014/07/11 20:33:40
Yes, but since I had a private section below I tho
| |
19 ClientInfo(); | |
20 | |
21 // The metrics ID of this client: represented as a GUID string. | |
22 std::string client_id; | |
Ilya Sherman
2014/07/11 04:45:41
nit: Please leave a blank line between adjacent do
gab
2014/07/11 20:33:40
Done.
| |
23 // The installation date: represented as an epoch time in seconds. | |
24 int64 installation_date; | |
25 // The date on which reporting was enabled: represented as an epoch time in | |
Ilya Sherman
2014/07/11 04:45:41
nit: "on which reporting was enabled" -> "on which
gab
2014/07/11 20:33:40
Done.
| |
26 // seconds. | |
27 int64 reporting_enabled_date; | |
28 | |
29 private: | |
30 DISALLOW_COPY_AND_ASSIGN(ClientInfo); | |
Ilya Sherman
2014/07/11 04:45:41
What's wrong with copy or assignment for this clas
gab
2014/07/11 20:33:40
I think the same argument to put DISALLOW_COPY_AND
| |
31 }; | |
32 | |
33 } // namespace metrics | |
34 | |
35 #endif // COMPONENTS_METRICS_CLIENT_INFO_H_ | |
OLD | NEW |