core/src/fpdfapi/fpdf_render/fpdf_render_text.cpp - Issue 372473003: Remove custom memory manager

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fpdfapi/fpdf_render/fpdf_render_text.cpp

Issue 372473003: Remove custom memory manager (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Change malloc to calloc Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/src/fpdfapi/fpdf_render/fpdf_render_text.cpp

diff --git a/core/src/fpdfapi/fpdf_render/fpdf_render_text.cpp b/core/src/fpdfapi/fpdf_render/fpdf_render_text.cpp

index a26d619565c25a27d1bdd0c6cb760167048efc33..fcb422b6c47a5f167a93eec4b8dac9016fe7ec60 100644

--- a/core/src/fpdfapi/fpdf_render/fpdf_render_text.cpp

+++ b/core/src/fpdfapi/fpdf_render/fpdf_render_text.cpp

@@ -390,7 +390,6 @@ FX_BOOL CPDF_RenderStatus::ProcessType3Text(const CPDF_TextObject* textobj, cons

FXTEXT_GLYPHPOS* pGlyphAndPos = NULL;

if (device_class == FXDC_DISPLAY) {

pGlyphAndPos = FX_Alloc(FXTEXT_GLYPHPOS, textobj->m_nChars);

- FXSYS_memset32(pGlyphAndPos, 0, sizeof(FXTEXT_GLYPHPOS) * textobj->m_nChars);

} else if (fill_alpha < 255) {

return FALSE;

}

@@ -540,7 +539,6 @@ void CPDF_CharPosList::Load(int nChars, FX_DWORD* pCharCodes, FX_FLOAT* pCharPos

FX_FLOAT FontSize)

{

m_pCharPos = FX_Alloc(FXTEXT_CHARPOS, nChars);

- FXSYS_memset32(m_pCharPos, 0, sizeof(FXTEXT_CHARPOS) * nChars);

m_nChars = 0;

CPDF_CIDFont* pCIDFont = pFont->GetCIDFont();

FX_BOOL bVertWriting = pCIDFont && pCIDFont->IsVertWriting();