core/src/fpdfapi/fpdf_page/fpdf_page_graph_state.cpp - Issue 372473003: Remove custom memory manager

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fpdfapi/fpdf_page/fpdf_page_graph_state.cpp

Issue 372473003: Remove custom memory manager (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Change malloc to calloc Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/src/fpdfapi/fpdf_page/fpdf_page_graph_state.cpp

diff --git a/core/src/fpdfapi/fpdf_page/fpdf_page_graph_state.cpp b/core/src/fpdfapi/fpdf_page/fpdf_page_graph_state.cpp

index 628fb3da996e7cd95b86851469beec38b3e6f996..8053718c190fef0413ae94c8a1857a2a30f136ca 100644

--- a/core/src/fpdfapi/fpdf_page/fpdf_page_graph_state.cpp

+++ b/core/src/fpdfapi/fpdf_page/fpdf_page_graph_state.cpp

@@ -71,7 +71,6 @@ CPDF_ClipPathData::CPDF_ClipPathData(const CPDF_ClipPathData& src)

m_TextCount = src.m_TextCount;

if (m_TextCount) {

m_pTextList = FX_Alloc(CPDF_TextObject*, m_TextCount);

- FXSYS_memset32(m_pTextList, 0, sizeof(CPDF_TextObject*) * m_TextCount);

for (int i = 0; i < m_TextCount; i ++) {

if (src.m_pTextList[i]) {

m_pTextList[i] = FX_NEW CPDF_TextObject;

@@ -96,7 +95,6 @@ void CPDF_ClipPathData::SetCount(int path_count, int text_count)

if (text_count) {

m_TextCount = text_count;

m_pTextList = FX_Alloc(CPDF_TextObject*, text_count);

- FXSYS_memset32(m_pTextList, 0, sizeof(void*) * text_count);

}

CPDF_Rect CPDF_ClipPath::GetClipBox() const