core/src/fpdfapi/fpdf_edit/fpdf_edit_doc.cpp - Issue 372473003: Remove custom memory manager

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fpdfapi/fpdf_edit/fpdf_edit_doc.cpp

Issue 372473003: Remove custom memory manager (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Change malloc to calloc Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/src/fpdfapi/fpdf_edit/fpdf_edit_doc.cpp

diff --git a/core/src/fpdfapi/fpdf_edit/fpdf_edit_doc.cpp b/core/src/fpdfapi/fpdf_edit/fpdf_edit_doc.cpp

index 2672116e4fb3d3be02bd9caf197b18e9da486609..9985f06dc6e6eed97cb01763e97e1cf0be11df91 100644

--- a/core/src/fpdfapi/fpdf_edit/fpdf_edit_doc.cpp

+++ b/core/src/fpdfapi/fpdf_edit/fpdf_edit_doc.cpp

@@ -543,8 +543,7 @@ static void _CFString2CFXByteString(CFStringRef src, CFX_ByteString &dest)

SInt32 len = CFStringGetLength(src);

CFRange range = CFRangeMake(0, len);

CFIndex used = 0;

- UInt8* pBuffer = (UInt8*)malloc(sizeof(UInt8) * (len + 1));

- FXSYS_memset32(pBuffer, 0, sizeof(UInt8) * (len + 1));

+ UInt8* pBuffer = (UInt8*)calloc(len+1, sizeof(UInt8));

CFStringGetBytes(src, range, kCFStringEncodingASCII, 0, false, pBuffer, len, &used);

dest = (FX_LPSTR)pBuffer;

free(pBuffer);

« no previous file with comments | « core/include/fxcrt/fx_xml.h ('k') | core/src/fpdfapi/fpdf_font/fpdf_font_cid.cpp » ('j') | no next file with comments »