Remove custom memory manager

core/src/fxcrt/fx_basic_plex.cpp

Index: core/src/fxcrt/fx_basic_plex.cpp
diff --git a/core/src/fxcrt/fx_basic_plex.cpp b/core/src/fxcrt/fx_basic_plex.cpp
index 80c014a2b3c6ff23b18c756cca756dfa7a83f894..bff55461f401fcce1a72e314d17fb11e80b85d99 100644
--- a/core/src/fxcrt/fx_basic_plex.cpp
+++ b/core/src/fxcrt/fx_basic_plex.cpp
@@ -1,14 +1,14 @@
 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
- 
+
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "../../include/fxcrt/fx_basic.h"
 #include "plex.h"
-CFX_Plex* CFX_Plex::Create(IFX_Allocator* pAllocator, CFX_Plex*& pHead, FX_DWORD nMax, FX_DWORD cbElement)
+CFX_Plex* CFX_Plex::Create(CFX_Plex*& pHead, FX_DWORD nMax, FX_DWORD cbElement)
 {
-    CFX_Plex* p = (CFX_Plex*)FX_Allocator_Alloc(pAllocator, FX_BYTE, sizeof(CFX_Plex) + nMax * cbElement);
+    CFX_Plex* p = (CFX_Plex*)FX_Alloc(FX_BYTE, sizeof(CFX_Plex) + nMax * cbElement);

[palmer, 2014/07/07 19:17:53]

Potential integer overflow here.

     if (!p) {
         return NULL;
     }
@@ -16,13 +16,13 @@ CFX_Plex* CFX_Plex::Create(IFX_Allocator* pAllocator, CFX_Plex*& pHead, FX_DWORD
     pHead = p;
     return p;
 }
-void CFX_Plex::FreeDataChain(IFX_Allocator* pAllocator)
+void CFX_Plex::FreeDataChain()
 {
     CFX_Plex* p = this;
     while (p != NULL) {
-        FX_BYTE* bytes = (FX_BYTE*) p;
+        FX_BYTE* bytes = (FX_BYTE*)p;
         CFX_Plex* pNext = p->pNext;
-        FX_Allocator_Free(pAllocator, bytes);
+        FX_Free(bytes);
         p = pNext;
     }
 }