Remove custom memory manager

core/src/fxcodec/codec/fx_codec.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
- 
+
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "../../../include/fxcodec/fx_codec.h"
 #include "codec_int.h"
 CCodec_ModuleMgr::CCodec_ModuleMgr()
 {
     m_pBasicModule = FX_NEW CCodec_BasicModule;
     m_pFaxModule = FX_NEW CCodec_FaxModule;
     m_pJpegModule = FX_NEW CCodec_JpegModule;
     m_pJpxModule = FX_NEW CCodec_JpxModule;
@@ skipping 97 matching lines @@
         dest_height = -dest_height;
     }
     v_DownScale(dest_width, dest_height);
     if (m_pDataCache) {
         if (m_pDataCache->m_Height == m_OutputHeight && m_pDataCache->m_Width == m_OutputWidth) {
             return;
         }
         FX_Free(m_pDataCache);
         m_pDataCache = NULL;
     }
-    m_pDataCache = (CCodec_ImageDataCache*)FXMEM_DefaultAlloc(
-                       sizeof(CCodec_ImageDataCache) + m_Pitch * m_OutputHeight, FXMEM_NONLEAVE);
+    m_pDataCache = (CCodec_ImageDataCache*)FX_AllocNL(FX_BYTE, sizeof(CCodec_ImageDataCache) + m_Pitch * m_OutputHeight);

[palmer, 2014/07/07 19:17:53]

Potential integer overflow here.

     if (m_pDataCache == NULL) {
         return;
     }
     m_pDataCache->m_Height = m_OutputHeight;
     m_pDataCache->m_Width = m_OutputWidth;
     m_pDataCache->m_nCachedLines = 0;
 }
 FX_BOOL CCodec_BasicModule::RunLengthEncode(const FX_BYTE* src_buf, FX_DWORD src_size, FX_LPBYTE& dest_buf,
         FX_DWORD& dest_size)
 {
@@ skipping 304 matching lines @@
     CCodec_RLScanlineDecoder* pRLScanlineDecoder = FX_NEW CCodec_RLScanlineDecoder;
     if (pRLScanlineDecoder == NULL) {
         return NULL;
     }
     if (!pRLScanlineDecoder->Create(src_buf, src_size, width, height, nComps, bpc)) {
         delete pRLScanlineDecoder;
         return NULL;
     }
     return pRLScanlineDecoder;
 }