Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issue 372473002: Add some Blink JS/CSS data resources (Closed)

Created:
6 years, 5 months ago by Jens Widell
Modified:
6 years, 5 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src@master
Project:
chromium
Visibility:
Public.

Description

Add some Blink JS/CSS data resources This makes the resources added in https://codereview.chromium.org/364323002/ available through blink::Platform::loadResource(). BUG=312586 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281534

Patch Set 1 #

Patch Set 2 : add temporary ifdef #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M content/child/blink_platform_impl.cc View 1 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
Jens Widell
PTAL
6 years, 5 months ago (2014-07-04 16:13:22 UTC) #1
jochen (gone - plz use gerrit)
lgtm
6 years, 5 months ago (2014-07-07 07:23:49 UTC) #2
Jens Widell
The CQ bit was checked by jl@opera.com
6 years, 5 months ago (2014-07-07 07:25:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jl@opera.com/372473002/1
6 years, 5 months ago (2014-07-07 07:26:36 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium ...
6 years, 5 months ago (2014-07-07 08:17:17 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-07 08:22:44 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/builds/158484)
6 years, 5 months ago (2014-07-07 08:22:45 UTC) #7
Jens Widell
On 2014/07/07 08:22:45, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
6 years, 5 months ago (2014-07-07 08:44:04 UTC) #8
Jens Widell
On 2014/07/07 08:44:04, Jens Lindström wrote: > On 2014/07/07 08:22:45, I haz the power (commit-bot) ...
6 years, 5 months ago (2014-07-07 09:09:51 UTC) #9
Jens Widell
The CQ bit was checked by jl@opera.com
6 years, 5 months ago (2014-07-07 09:10:30 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jl@opera.com/372473002/20001
6 years, 5 months ago (2014-07-07 09:11:02 UTC) #11
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-07 13:00:14 UTC) #12
commit-bot: I haz the power
6 years, 5 months ago (2014-07-07 14:42:11 UTC) #13
Message was sent while issue was closed.
Change committed as 281534

Powered by Google App Engine
This is Rietveld 408576698