content/browser/frame_host/navigation_controller_impl.cc - Issue 372403002: Allow "cross-origin" navigations from about:blank in AreURLsInPageNavigation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/navigation_controller_impl.cc

Issue 372403002: Allow "cross-origin" navigations from about:blank in AreURLsInPageNavigation (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/frame_host/navigation_controller_impl.cc

diff --git a/content/browser/frame_host/navigation_controller_impl.cc b/content/browser/frame_host/navigation_controller_impl.cc

index a751ccd3da09dd5b6223138a65e5fe20776e9635..00d12edf37e3c621f91227bcffbf848b94c999c0 100644

--- a/content/browser/frame_host/navigation_controller_impl.cc

+++ b/content/browser/frame_host/navigation_controller_impl.cc

@@ -123,6 +123,7 @@ bool AreURLsInPageNavigation(const GURL& existing_url,

RenderFrameHost* rfh) {

WebPreferences prefs = rfh->GetRenderViewHost()->GetWebkitPreferences();

bool is_same_origin = existing_url.is_empty() ||

+ existing_url == GURL(url::kAboutBlankURL) ||

nasko 2014/07/09 07:11:17 Shouldn't this only apply if there is no session h

existing_url.GetOrigin() == new_url.GetOrigin() ||

!prefs.web_security_enabled;

if (!is_same_origin && renderer_says_in_page)

« no previous file with comments | « no previous file | content/browser/frame_host/navigation_controller_impl_unittest.cc » ('j') | no next file with comments »