Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Issue 372373002: Fixing notification message crash on fast dismissal click (Closed)

Created:
6 years, 5 months ago by Mr4D (OOO till 08-26)
Modified:
6 years, 5 months ago
Reviewers:
jennyz
CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org
Project:
chromium
Visibility:
Public.

Description

Fixing notification message crash on fast dismissal click BUG=392096 TEST=visual Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281922

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -5 lines) Patch
M ash/system/user/user_view.h View 2 chunks +7 lines, -0 lines 0 comments Download
M ash/system/user/user_view.cc View 2 chunks +10 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Mr4D (OOO till 08-26)
Please have a look!
6 years, 5 months ago (2014-07-08 19:16:28 UTC) #1
jennyz
lgtm
6 years, 5 months ago (2014-07-08 20:41:23 UTC) #2
Mr4D (OOO till 08-26)
The CQ bit was checked by skuhne@chromium.org
6 years, 5 months ago (2014-07-08 20:58:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skuhne@chromium.org/372373002/1
6 years, 5 months ago (2014-07-08 21:01:29 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 5 months ago (2014-07-09 01:26:10 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-09 04:15:41 UTC) #6
Message was sent while issue was closed.
Change committed as 281922

Powered by Google App Engine
This is Rietveld 408576698