Issue 372323003: Use stack allocation for Android data in SkScalerContext::MakeRec().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 372323003: Use stack allocation for Android data in SkScalerContext::MakeRec(). (Closed)

Created:
6 years, 5 months ago by jvanverth1

Modified:
6 years, 5 months ago

Reviewers:
bsalomon, reed1

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

More Reviews

Description

Use stack allocation for Android data in SkScalerContext::MakeRec(). In a perfvis run on the "Boogie" test page, descriptorProc() during detachCache() was taking .721 ms, and 20% of that was the flatten() in MakeRec(). Changing this to a smaller stack allocation reduces the time for descriptorProc() to .556 ms. Committed: https://skia.googlesource.com/skia/+/65b6fa177798089a3556643f765fbbca5a4a5185

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	src/core/SkPaint.cpp	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/jvanverth@google.com/372323003/1

6 years, 5 months ago (2014-07-08 17:50:27 UTC) #5

commit-bot: I haz the power

6 years, 5 months ago (2014-07-08 18:15:52 UTC) #6

Message was sent while issue was closed.

Change committed as 65b6fa177798089a3556643f765fbbca5a4a5185

Expand Messages | Collapse Messages