Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1325)

Issue 372243003: Four new pages added to tough_scheduling_cases (Closed)

Created:
6 years, 5 months ago by picksi1
Modified:
6 years, 3 months ago
CC:
chromium-reviews, telemetry+watch_chromium.org, Yufeng Shen (Slow to review), Rick Byers
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Long line fixed #

Patch Set 3 : Testing new pages in tough_scheduleing_cases on try-bot #

Patch Set 4 : Update to run-perf-test.cfg #

Patch Set 5 : Removal of incorrect WPR file reference #

Total comments: 2

Patch Set 6 : White space fixup #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -1 line) Patch
A tools/perf/page_sets/data/tough_scheduling_cases.json View 2 1 chunk +11 lines, -0 lines 1 comment Download
A tools/perf/page_sets/data/tough_scheduling_cases_000.wpr.sha1 View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M tools/perf/page_sets/tough_scheduling_cases.py View 1 2 3 4 5 2 chunks +13 lines, -1 line 0 comments Download

Messages

Total messages: 32 (0 generated)
picksi
Please review this code to add new pages to the touch_scheduling_cases to the page-set. There ...
6 years, 5 months ago (2014-07-08 13:08:55 UTC) #1
jdduke (slow)
On 2014/07/08 13:08:55, picksi wrote: > Please review this code to add new pages to ...
6 years, 5 months ago (2014-07-08 15:20:53 UTC) #2
jdduke (slow)
miletus@: These tests stress scheduling around page load. Is there anything we should be doing ...
6 years, 5 months ago (2014-07-08 18:27:01 UTC) #3
Yufeng Shen (Slow to review)
On 2014/07/08 18:27:01, jdduke wrote: > miletus@: These tests stress scheduling around page load. Is ...
6 years, 5 months ago (2014-07-08 21:59:46 UTC) #4
Yufeng Shen (Slow to review)
On 2014/07/08 18:27:01, jdduke wrote: > miletus@: These tests stress scheduling around page load. Is ...
6 years, 5 months ago (2014-07-08 21:59:46 UTC) #5
jdduke (slow)
On 2014/07/08 21:59:46, Yufeng Shen wrote: > The other thing is that even though the ...
6 years, 5 months ago (2014-07-08 22:23:30 UTC) #6
Dominik Grewe
On 2014/07/08 21:59:46, Yufeng Shen wrote: > On 2014/07/08 18:27:01, jdduke wrote: > > miletus@: ...
6 years, 5 months ago (2014-07-09 09:20:10 UTC) #7
picksi
<snip>maybe the average of the first 3 input events' latency, to reflect what we are ...
6 years, 5 months ago (2014-07-09 10:40:00 UTC) #8
picksi
After thinking about this some more, I'm going to measure how long the input-latency takes ...
6 years, 5 months ago (2014-07-09 19:54:41 UTC) #9
Sami
I think we can land this and figure out the metric we want separately. Thus: ...
6 years, 5 months ago (2014-07-11 14:38:09 UTC) #10
picksi
The CQ bit was checked by picksi@google.com
6 years, 5 months ago (2014-07-11 15:04:42 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/picksi@chromium.org/372243003/1
6 years, 5 months ago (2014-07-11 15:05:23 UTC) #12
picksi
The CQ bit was checked by picksi@google.com
6 years, 5 months ago (2014-07-11 17:44:44 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/picksi@chromium.org/372243003/20001
6 years, 5 months ago (2014-07-11 17:46:35 UTC) #14
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win8_chromium_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-11 23:13:21 UTC) #15
commit-bot: I haz the power
Change committed as 282740
6 years, 5 months ago (2014-07-11 23:55:09 UTC) #16
tonyg
A revert of this CL has been created in https://codereview.chromium.org/388053002/ by tonyg@chromium.org. The reason for ...
6 years, 5 months ago (2014-07-12 23:02:23 UTC) #17
picksi
Revert of reverted code + removal of reference to an unused WPR file. Assuming initial ...
6 years, 5 months ago (2014-07-15 11:31:11 UTC) #18
Sami
lgtm. Given that this works locally, let's give it another run through the bots and ...
6 years, 5 months ago (2014-07-16 10:32:01 UTC) #19
picksi
Tabs fixed. Re-committing this now. https://codereview.chromium.org/372243003/diff/80001/tools/perf/page_sets/tough_scheduling_cases.py File tools/perf/page_sets/tough_scheduling_cases.py (right): https://codereview.chromium.org/372243003/diff/80001/tools/perf/page_sets/tough_scheduling_cases.py#newcode471 tools/perf/page_sets/tough_scheduling_cases.py:471: 'http://www.latimes.com', On 2014/07/16 10:32:01, ...
6 years, 5 months ago (2014-07-18 09:23:07 UTC) #20
picksi
The CQ bit was checked by picksi@google.com
6 years, 5 months ago (2014-07-18 09:23:32 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/picksi@chromium.org/372243003/100001
6 years, 5 months ago (2014-07-18 09:26:23 UTC) #22
commit-bot: I haz the power
Change committed as 284060
6 years, 5 months ago (2014-07-18 11:31:02 UTC) #23
tonyg
A revert of this CL has been created in https://codereview.chromium.org/406783002/ by tonyg@chromium.org. The reason for ...
6 years, 5 months ago (2014-07-19 20:33:44 UTC) #24
picksi
There is already *some* unittest coverage for tough_scheduling_cases. The availability of archived data, credentials and ...
6 years, 5 months ago (2014-07-22 13:52:47 UTC) #25
Sami
On 2014/07/22 13:52:47, picksi wrote: > There is already *some* unittest coverage for tough_scheduling_cases. The ...
6 years, 5 months ago (2014-07-22 14:02:13 UTC) #26
picksi
The additions of the 4 new pages to tough_scheduling_cases automatically adds them to PageSetSmokeTest, so ...
6 years, 5 months ago (2014-07-22 14:23:34 UTC) #27
picksi
These pages are also missing on the bots, scroll to the bottom of the following ...
6 years, 5 months ago (2014-07-22 17:04:35 UTC) #28
jdduke (slow)
On 2014/07/22 17:04:35, picksi wrote: > These pages are also missing on the bots, scroll ...
6 years, 4 months ago (2014-08-21 19:26:51 UTC) #29
picksi1
Sami reminded me about these missing pages yesterday. I'm Sheriffing or on holiday until next ...
6 years, 4 months ago (2014-08-22 12:36:02 UTC) #30
jdduke (slow)
I tested each page set locally, and they seemed to run just fine. The usatoday, ...
6 years, 3 months ago (2014-08-26 15:46:20 UTC) #31
picksi1
6 years, 3 months ago (2014-09-01 14:56:33 UTC) #32
Message was sent while issue was closed.
I've added theses pages (except io9) to key_mobiles_sites under a different cl
(here: https://codereview.chromium.org/525493003/).

Powered by Google App Engine
This is Rietveld 408576698