Issue 372233002: Style and layout should be done before getting value for x() and y()

Issue 372233002: Style and layout should be done before getting value for x() and y() (Closed)

Created:
6 years, 5 months ago by je_julie(Not used)

Modified:
6 years, 5 months ago

Reviewers:
esprehn, dmazzoni

CC:
blink-reviews, blink-reviews-html_chromium.org, dglazkov+blink

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

More Reviews

Description

According to CSSOM-View, interface HTMLImageElement, The x attribute must return the x-coordinate. If style is not updated when x() is called, it can't return anything. Style and layout should be done before getting value for x() and y(). The patch was originally written by me <je_julie.kim@samsung.com>; in wkrev.com/166833 and the test case was originally written by Alan Stearns<stearns@adobe.com>;. BUG=392094 R=esprehn@chromium.org TEST=cssom/cssom-view-img-attributes-001.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178011

Patch Set 1 #

Total comments: 2

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+57 lines, -0 lines)			Patch
A	LayoutTests/cssom/cssom-view-img-attributes-001.html	View	1 chunk	+48 lines, -0 lines	2 comments	Download
A	LayoutTests/cssom/cssom-view-img-attributes-001-expected.txt	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	Source/core/html/HTMLImageElement.cpp	View	2 chunks	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 14 (0 generated)

Expand Messages | Collapse Messages

je_julie(Not used)

On 2014/07/08 09:33:31, je_julie.kim wrote: PTAL

6 years, 5 months ago (2014-07-08 14:01:17 UTC) #2

je_julie(Not used)

On 2014/07/08 14:59:02, dmazzoni wrote: > +esprehn - I'm not the best reviewer for this ...

6 years, 5 months ago (2014-07-09 10:27:11 UTC) #4

je_julie(Not used)

On 2014/07/11 00:01:48, esprehn wrote: > Did this test really come from adobe? On WebKit, ...

6 years, 5 months ago (2014-07-11 00:14:07 UTC) #6

esprehn

You need to give credit to the webkit author in your patch description and reference ...

6 years, 5 months ago (2014-07-11 00:24:44 UTC) #7

je_julie(Not used)

On 2014/07/11 00:24:44, esprehn wrote: > You need to give credit to the webkit author ...

6 years, 5 months ago (2014-07-11 03:23:43 UTC) #8

esprehn

lgtm https://codereview.chromium.org/372233002/diff/1/LayoutTests/cssom/cssom-view-img-attributes-001.html File LayoutTests/cssom/cssom-view-img-attributes-001.html (right): https://codereview.chromium.org/372233002/diff/1/LayoutTests/cssom/cssom-view-img-attributes-001.html#newcode3 LayoutTests/cssom/cssom-view-img-attributes-001.html:3: <head> We usually leave off the html and ...

6 years, 5 months ago (2014-07-11 03:45:57 UTC) #9

je_julie(Not used)

https://codereview.chromium.org/372233002/diff/1/LayoutTests/cssom/cssom-view-img-attributes-001.html File LayoutTests/cssom/cssom-view-img-attributes-001.html (right): https://codereview.chromium.org/372233002/diff/1/LayoutTests/cssom/cssom-view-img-attributes-001.html#newcode3 LayoutTests/cssom/cssom-view-img-attributes-001.html:3: <head> On 2014/07/11 03:45:57, esprehn wrote: > We usually ...

6 years, 5 months ago (2014-07-11 04:04:55 UTC) #10

je_julie(Not used)

The CQ bit was checked by je_julie.kim@samsung.com

6 years, 5 months ago (2014-07-13 08:04:06 UTC) #11

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/je_julie.kim@samsung.com/372233002/1

6 years, 5 months ago (2014-07-13 08:04:28 UTC) #12

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...

6 years, 5 months ago (2014-07-13 09:06:22 UTC) #13

Message was sent while issue was closed.

Change committed as 178011

Expand Messages | Collapse Messages