Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 372223002: Remove metrics for XMLHttpRequest.send(ArrayBuffer). (Closed)

Created:
6 years, 5 months ago by pwnall-personal
Modified:
6 years, 5 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Remove metrics for XMLHttpRequest.send(ArrayBuffer). Using an ArrayBuffer as the argument to XMLHttpRequest.send() is no longer deprecated in the latest WHATWG spec, according to https://www.w3.org/Bugs/Public/show_bug.cgi?id=26153#c1 This change removes the metrics used by the deprecation process. The deprecation warnings will be removed in the Blink-side CL below. https://codereview.chromium.org/373023002/ BUG=237493 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281956

Patch Set 1 #

Patch Set 2 : Addressed feedback. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M tools/metrics/histograms/histograms.xml View 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
pwnall-personal
Can you please take a look?
6 years, 5 months ago (2014-07-08 10:28:05 UTC) #1
Ilya Sherman
Please instead mark the histogram as <obsolete> (and leave the enum in place).
6 years, 5 months ago (2014-07-08 23:04:19 UTC) #2
pwnall-personal
On 2014/07/08 23:04:19, Ilya Sherman wrote: > Please instead mark the histogram as <obsolete> (and ...
6 years, 5 months ago (2014-07-08 23:26:10 UTC) #3
Ilya Sherman
LGTM, thanks.
6 years, 5 months ago (2014-07-08 23:32:08 UTC) #4
Ilya Sherman
The CQ bit was checked by isherman@chromium.org
6 years, 5 months ago (2014-07-08 23:32:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/costan@gmail.com/372223002/40001
6 years, 5 months ago (2014-07-08 23:34:39 UTC) #6
pwnall-personal
On 2014/07/08 23:32:08, Ilya Sherman wrote: > LGTM, thanks. Thank *you* for the quick turnaround!
6 years, 5 months ago (2014-07-09 00:12:27 UTC) #7
tyoshino (SeeGerritForStatus)
lgtm. thanks
6 years, 5 months ago (2014-07-09 04:30:22 UTC) #8
commit-bot: I haz the power
6 years, 5 months ago (2014-07-09 05:33:47 UTC) #9
Message was sent while issue was closed.
Change committed as 281956

Powered by Google App Engine
This is Rietveld 408576698