Makefile.standalone - Issue 372133002: Subzero: Add "make format-diff" target.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Makefile.standalone

Issue 372133002: Subzero: Add "make format-diff" target. (Closed) Base URL: https://gerrit.chromium.org/gerrit/p/native_client/pnacl-subzero.git@master

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 # The following variables will likely need to be modified, depending on where	1 # The following variables will likely need to be modified, depending on where

2 # and how you built LLVM & Clang. They can be overridden in a command-line	2 # and how you built LLVM & Clang. They can be overridden in a command-line

3 # invocation of make, like:	3 # invocation of make, like:

4 #	4 #

5 # make LLVM_SRC_PATH=<path> LLVM_BIN_PATH=<path> ...	5 # make LLVM_SRC_PATH=<path> LLVM_BIN_PATH=<path> ...

6 #	6 #

7	7

8 # LLVM_SRC_PATH is the path to the root of the checked out source code. This	8 # LLVM_SRC_PATH is the path to the root of the checked out source code. This

9 # directory should contain the configure script, the include/ and lib/	9 # directory should contain the configure script, the include/ and lib/

10 # directories of LLVM, Clang in tools/clang/, etc.	10 # directories of LLVM, Clang in tools/clang/, etc.

(...skipping 60 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
71 @mkdir -p $@	71 @mkdir -p $@

72	72

73 check: llvm2ice	73 check: llvm2ice

74 LLVM_BIN_PATH=$(LLVM_BIN_PATH) \	74 LLVM_BIN_PATH=$(LLVM_BIN_PATH) \

75 $(LLVM_SRC_PATH)/utils/lit/lit.py -sv tests_lit	75 $(LLVM_SRC_PATH)/utils/lit/lit.py -sv tests_lit

76 (cd crosstest; LLVM_BIN_PATH=$(LLVM_BIN_PATH) ./runtests.sh)	76 (cd crosstest; LLVM_BIN_PATH=$(LLVM_BIN_PATH) ./runtests.sh)

77	77

78 # TODO: Fix the use of wildcards.	78 # TODO: Fix the use of wildcards.

79 format:	79 format:

80 $(LLVM_BIN_PATH)/clang-format -style=LLVM -i \	80 $(LLVM_BIN_PATH)/clang-format -style=LLVM -i \

81 src/Ice.h src/Ice.cpp src/llvm2ice.cpp	81 src/Ice.h src/Ice.cpp src/llvm2ice.cpp
	jvoung (off chromium) 2014/07/08 23:56:24 btw, I think the reason Karl missed clang-formatti btw, I think the reason Karl missed clang-formatting PNaClTranslator.cpp is because it's missing from this list.
82	82

	83 # Assumes clang-format-diff.py is within $PATH, and that the

	84 # clang-format it calls is also within $PATH. This may require adding

	85 # /usr/lib/clang-format to $PATH.

	86 format-diff:

	87 git diff -U0 HEAD^ \| \

	88 /usr/lib/clang-format/clang-format-diff.py -p1 -style=LLVM -i
	jvoung (off chromium) 2014/07/08 23:56:24 Not sure of a better way... my desktop definitely Not sure of a better way... my desktop definitely has this, but my laptop does not. There is a clang-format-diff.py script in the CLANG_SRC_PATH, but I think it assumes the user has "clang-format" in the PATH.
	89

83 clean:	90 clean:

84 rm -rf llvm2ice *.o build/	91 rm -rf llvm2ice *.o build/

OLD	NEW

« no previous file with comments | « no previous file | no next file » | no next file with comments »