Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 37213005: Update scummvm to 1.6.0, also make it a packaged app. (Closed)

Created:
7 years, 2 months ago by binji
Modified:
7 years, 1 month ago
Reviewers:
Sam Clegg
CC:
native-client-reviews_googlegroups.com
Visibility:
Public.

Description

Update scummvm to 1.6.0, also make it a packaged app. BUG=none R=sbc@chromium.org Committed: https://code.google.com/p/naclports/source/detail?r=940

Patch Set 1 #

Patch Set 2 : chunk mismatch #

Patch Set 3 : again #

Patch Set 4 : again #

Patch Set 5 : use default .scummvmrc to have games automatically "loaded" #

Total comments: 3

Patch Set 6 : fix ARM build, remove "whole archive" #

Total comments: 1

Patch Set 7 : use whole-archive again #

Patch Set 8 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+311 lines, -840 lines) Patch
M Makefile View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
D examples/games/scummvm/hosted_app/manifest.json View 1 chunk +0 lines, -17 lines 0 comments Download
D examples/games/scummvm/hosted_app/scummvm_128.png View Binary file 0 comments Download
D examples/games/scummvm/hosted_app/scummvm_16.png View Binary file 0 comments Download
M examples/games/scummvm/nacl.patch View 1 2 3 4 12 chunks +186 lines, -510 lines 0 comments Download
D examples/games/scummvm/nacl-scumm/AppEngineMount.py View 1 chunk +0 lines, -151 lines 0 comments Download
D examples/games/scummvm/nacl-scumm/README View 1 chunk +0 lines, -6 lines 0 comments Download
D examples/games/scummvm/nacl-scumm/app.yaml View 1 chunk +0 lines, -12 lines 0 comments Download
D examples/games/scummvm/nacl-scumm/index.html View 1 chunk +0 lines, -72 lines 0 comments Download
D examples/games/scummvm/nacl-scumm/index.yaml View 1 chunk +0 lines, -16 lines 0 comments Download
D examples/games/scummvm/nacl-scumm/static/scummvm.nmf View 1 chunk +0 lines, -10 lines 0 comments Download
M examples/games/scummvm/nacl-scummvm.sh View 1 2 3 4 5 6 3 chunks +54 lines, -34 lines 0 comments Download
A examples/games/scummvm/packaged_app/background.js View 1 2 3 4 1 chunk +13 lines, -0 lines 0 comments Download
A examples/games/scummvm/packaged_app/index.html View 1 2 3 4 1 chunk +25 lines, -0 lines 0 comments Download
examples/games/scummvm/packaged_app/manifest.json View 1 chunk +6 lines, -6 lines 0 comments Download
A + examples/games/scummvm/packaged_app/scummvm_128.png View Binary file 0 comments Download
A + examples/games/scummvm/packaged_app/scummvm_16.png View Binary file 0 comments Download
A examples/games/scummvm/packaged_app/scummvmrc View 1 2 3 4 1 chunk +21 lines, -0 lines 0 comments Download
M examples/games/scummvm/pkg_info View 1 chunk +3 lines, -3 lines 0 comments Download
D examples/games/scummvm/scummvm-1.2.1.sha1 View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download
A examples/games/scummvm/scummvm-1.6.0.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
binji
7 years, 2 months ago (2013-10-24 01:46:26 UTC) #1
Sam Clegg
Awesome! LGTM. Did you forget to delete the old .sha1 file? Also, remember to run ...
7 years, 2 months ago (2013-10-25 02:08:24 UTC) #2
binji
https://codereview.chromium.org/37213005/diff/150001/examples/games/scummvm/nacl-scummvm.sh File examples/games/scummvm/nacl-scummvm.sh (right): https://codereview.chromium.org/37213005/diff/150001/examples/games/scummvm/nacl-scummvm.sh#newcode64 examples/games/scummvm/nacl-scummvm.sh:64: export LIBS="$LIBS -Wl,--no-whole-archive" On 2013/10/25 02:08:24, Sam Clegg wrote: ...
7 years, 1 month ago (2013-10-26 01:13:42 UTC) #3
Sam Clegg
https://codereview.chromium.org/37213005/diff/280001/libraries/SDL/nacl.patch File libraries/SDL/nacl.patch (right): https://codereview.chromium.org/37213005/diff/280001/libraries/SDL/nacl.patch#newcode69 libraries/SDL/nacl.patch:69: + SDL_LIBS="-Wl,--start-group -lSDLmain -lnacl_io $SDL_LIBS -lppapi -lppapi_cpp -lppapi_gles2 -Wl,--end-group ...
7 years, 1 month ago (2013-10-26 01:20:51 UTC) #4
binji
OK, reverted.
7 years, 1 month ago (2013-10-26 17:18:11 UTC) #5
binji
7 years, 1 month ago (2013-10-26 17:20:52 UTC) #6
Message was sent while issue was closed. 
Committed patchset #8 manually as r940 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698