content/renderer/pepper/plugin_object.cc - Issue 372093002: Fixes for re-enabling more MSVC level 4 warnings: content/renderer/ edition

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/pepper/plugin_object.cc

Issue 372093002: Fixes for re-enabling more MSVC level 4 warnings: content/renderer/ edition (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Review comment Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/renderer/pepper/plugin_object.cc

diff --git a/content/renderer/pepper/plugin_object.cc b/content/renderer/pepper/plugin_object.cc

index 6de7ce19efb3189bca654cddcce38bc4ea27eeb4..256c0a3fd76e8813a963e334212dd7ca23240a53 100644

--- a/content/renderer/pepper/plugin_object.cc

+++ b/content/renderer/pepper/plugin_object.cc

@@ -208,7 +208,8 @@ bool WrapperClass_Enumerate(NPObject* object,

calloc(property_count, sizeof(NPIdentifier)));

*count = 0; // Will be the number of items successfully converted.

for (uint32_t i = 0; i < property_count; ++i) {

- if (!((*values)[i] = PPVarToNPIdentifier(properties[i]))) {

+ (*values)[i] = PPVarToNPIdentifier(properties[i]);

+ if (!(*values)[i]) {

// Throw an exception for the failed convertion.

*result_converter.exception() =

StringVar::StringToPPVar(kInvalidValueException);

« no previous file with comments | « content/renderer/pepper/plugin_module.cc ('k') | content/renderer/render_view_impl.cc » ('j') | no next file with comments »