Fixes for re-enabling more MSVC level 4 warnings: content/renderer/ edition

Fixes for re-enabling more MSVC level 4 warnings: content/renderer/ edition

This contains fixes for the following sorts of issues:
* Signedness mismatch
* Assignment inside conditional
* Possibly-uninitialized local variable

This also contains a style fix (wrong indentation on class section markers).

BUG=81439
TEST=none
R=jamesr@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281637

[jamesr, 2014-07-07 22:48:07]

Please s/browser/renderer/ in the patch subject and description.

lgtm

https://codereview.chromium.org/372093002/diff/1/content/renderer/gpu/composi...
File content/renderer/gpu/compositor_software_output_device.cc (right):

https://codereview.chromium.org/372093002/diff/1/content/renderer/gpu/composi...
content/renderer/gpu/compositor_software_output_device.cc:20: static const
size_t kInvalidIndex = static_cast<size_t>(-1);
the anonymous namespace and the 'static' are redundant, aren't they? could you
pick one?

[Peter Kasting, 2014-07-07 22:52:19]

On 2014/07/07 22:48:07, jamesr wrote:
> Please s/browser/renderer/ in the patch subject and description.

Whoops.  The perils of copy and paste.  Fixed.

https://codereview.chromium.org/372093002/diff/1/content/renderer/gpu/composi...
File content/renderer/gpu/compositor_software_output_device.cc (right):

https://codereview.chromium.org/372093002/diff/1/content/renderer/gpu/composi...
content/renderer/gpu/compositor_software_output_device.cc:20: static const
size_t kInvalidIndex = static_cast<size_t>(-1);
On 2014/07/07 22:48:07, jamesr wrote:
> the anonymous namespace and the 'static' are redundant, aren't they?

Yes.  Sorry.  Dropping the "static".

[Peter Kasting, 2014-07-07 22:52:23]

The CQ bit was checked by pkasting@chromium.org

[commit-bot: I haz the power, 2014-07-07 22:53:25]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/pkasting@chromium.org/372093002/20001

[commit-bot: I haz the power, 2014-07-08 01:41:48]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/9...)

[commit-bot: I haz the power, 2014-07-08 02:29:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-08 02:29:35]

Try jobs failed on following builders:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/9...)

[Peter Kasting, 2014-07-08 02:36:25]

Committed patchset #2 manually as r281637 (presubmit successful).