Issue 372051: Mac: Let status bubble dodge to the right if necessary.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 372051: Mac: Let status bubble dodge to the right if necessary. (Closed)

Created:
11 years, 1 month ago by Nico

Modified:
9 years, 7 months ago

Reviewers:
Avi (use Gerrit), viettrungluu

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Mac: Let status bubble dodge to the right if necessary. Windows seems to do this either if a shelf is visible or if the status bubble would slide off screen, so chrome/mac now does that too :-/ Note that the right-aligned bubble overlaps a vertical scrollbar if present. That matches windows. BUG=22198 TEST=See bug. Also test that if both popup block bubble and status bubble are at the right, the status bubble should be on top of the popup block bubble. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=31428

Patch Set 1 #

Patch Set 2 : correct curve #

Patch Set 3 : move to the right if bubble would leave screen #

Total comments: 4

Patch Set 4 : address comments #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -15 lines)			Patch
	M	chrome/browser/cocoa/status_bubble_mac.mm	View	1 2 3	2 chunks	+31 lines, -14 lines	0 comments	Download
	M	chrome/browser/views/status_bubble_views.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Avi (use Gerrit)

LG http://codereview.chromium.org/372051/diff/4001/5001 File chrome/browser/cocoa/status_bubble_mac.mm (right): http://codereview.chromium.org/372051/diff/4001/5001#newcode234 Line 234: blank line not necessary http://codereview.chromium.org/372051/diff/4001/5001#newcode274 Line 274: ...

11 years, 1 month ago (2009-11-09 15:41:42 UTC) #2

Nico

11 years, 1 month ago (2009-11-09 16:09:54 UTC) #3

Thanks, submitting.

http://codereview.chromium.org/372051/diff/4001/5001
File chrome/browser/cocoa/status_bubble_mac.mm (right):

http://codereview.chromium.org/372051/diff/4001/5001#newcode234
Line 234: 
On 2009/11/09 15:41:42, Avi wrote:
> blank line not necessary

Done.

http://codereview.chromium.org/372051/diff/4001/5001#newcode274
Line 274: // Substract border width + bubble width.
On 2009/11/09 15:41:42, Avi wrote:
> subtract

Done, also done in the windows version.

Expand Messages | Collapse Messages