Issue 372047: Fixed worker startup issue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 372047: Fixed worker startup issue (Closed)

Created:
11 years, 1 month ago by Andrew T Wilson (Slow)

Modified:
9 years, 7 months ago

Reviewers:
jam

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Changed SharedWorkerScriptLoader and WebSharedWorkerProxy to stay alive until worker initialization is complete (they were being freed before the connect event was sent to the worker. BUG=26233 TEST=none (will be enabled after a separate upstream patch is landed) Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=31417

Patch Set 1 #

Patch Set 2 : Removed tests to a separate patch. #

Total comments: 2

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+78 lines, -26 lines)			Patch
M	chrome/renderer/websharedworker_proxy.h	View		2 chunks	+4 lines, -1 line	0 comments	Download
M	chrome/renderer/websharedworker_proxy.cc	View		4 chunks	+17 lines, -2 lines	1 comment	Download
M	chrome/renderer/webworker_base.h	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/worker/websharedworker_stub.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/api/public/WebSharedWorker.h	View	1	1 chunk	+7 lines, -2 lines	1 comment	Download
M	webkit/api/src/SharedWorkerRepository.cpp	View		4 chunks	+42 lines, -18 lines	0 comments	Download
M	webkit/api/src/WebSharedWorkerImpl.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/api/src/WebSharedWorkerImpl.cpp	View		2 chunks	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Andrew T Wilson (Slow)

I have a set of unit tests that pass locally that I'll turn on once ...

11 years, 1 month ago (2009-11-08 06:35:33 UTC) #1

jam

11 years, 1 month ago (2009-11-09 02:53:03 UTC) #2

lgtm

http://codereview.chromium.org/372047/diff/1001/1002
File chrome/renderer/websharedworker_proxy.cc (right):

http://codereview.chromium.org/372047/diff/1001/1002#newcode74
Line 74: m_connectListener->connected();
nit: chrome style is not to use brace brackets for one line statements

http://codereview.chromium.org/372047/diff/1001/1006
File webkit/api/public/WebSharedWorker.h (right):

http://codereview.chromium.org/372047/diff/1001/1006#newcode65
Line 65: public:
nit: the spacing here should conform to WebKit style

Expand Messages | Collapse Messages