Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(735)

Issue 371983003: Remove SK_DISABLE_PIXELREF_LOCKCOUNT_BALANCE_CHECK. (Closed)

Created:
6 years, 5 months ago by mtklein_C
Modified:
6 years, 5 months ago
Reviewers:
scroggo, mtklein, reed1
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove SK_DISABLE_PIXELREF_LOCKCOUNT_BALANCE_CHECK. Skia no longer looks at this define. It's as if it's always set now. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281737

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -8 lines) Patch
M skia/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
M skia/skia_common.gypi View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
mtklein
6 years, 5 months ago (2014-07-07 19:12:35 UTC) #1
mtklein
+scroggo, since you've got the context from the other CL. Same deal, now in Chromium ...
6 years, 5 months ago (2014-07-07 19:19:55 UTC) #2
scroggo
LGTM, though I'm not sure mine is enough.
6 years, 5 months ago (2014-07-07 19:20:48 UTC) #3
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 5 months ago (2014-07-07 19:21:04 UTC) #4
mtklein
On 2014/07/07 19:20:48, scroggo wrote: > LGTM, though I'm not sure mine is enough. We'll ...
6 years, 5 months ago (2014-07-07 19:21:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtklein@chromium.org/371983003/1
6 years, 5 months ago (2014-07-07 19:22:49 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-07 19:22:51 UTC) #7
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 5 months ago (2014-07-07 19:22:51 UTC) #8
reed1
lgtm
6 years, 5 months ago (2014-07-07 19:33:33 UTC) #9
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 5 months ago (2014-07-07 19:34:14 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtklein@chromium.org/371983003/1
6 years, 5 months ago (2014-07-07 19:35:42 UTC) #11
mtklein
The CQ bit was unchecked by mtklein@google.com
6 years, 5 months ago (2014-07-07 19:42:42 UTC) #12
mtklein
On 2014/07/07 19:42:42, mtklein wrote: > The CQ bit was unchecked by mailto:mtklein@google.com Whoops, duh, ...
6 years, 5 months ago (2014-07-07 19:43:03 UTC) #13
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 5 months ago (2014-07-08 11:49:09 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtklein@chromium.org/371983003/1
6 years, 5 months ago (2014-07-08 11:49:47 UTC) #15
commit-bot: I haz the power
6 years, 5 months ago (2014-07-08 13:26:18 UTC) #16
Message was sent while issue was closed.
Change committed as 281737

Powered by Google App Engine
This is Rietveld 408576698