x509_certificate_model_openssl: implement ProcessSubjectPublicKeyInfo

x509_certificate_model_openssl: implement ProcessSubjectPublicKeyInfo

BUG=338887
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282213

[Ryan Sleevi, 2014-07-07 19:53:42]

lgtm

https://codereview.chromium.org/371953003/diff/1/chrome/common/net/x509_certi...
File chrome/common/net/x509_certificate_model_openssl.cc (right):

https://codereview.chromium.org/371953003/diff/1/chrome/common/net/x509_certi...
chrome/common/net/x509_certificate_model_openssl.cc:51: BN_bn2bin(n, buf.get());
nit: A bit of a code-smell to ignore a result. Though the implementation always
returns BN_num_bytes, it's not guaranteed by the API contract (just implied)

[mattm, 2014-07-07 21:32:56]

https://codereview.chromium.org/371953003/diff/1/chrome/common/net/x509_certi...
File chrome/common/net/x509_certificate_model_openssl.cc (right):

https://codereview.chromium.org/371953003/diff/1/chrome/common/net/x509_certi...
chrome/common/net/x509_certificate_model_openssl.cc:51: BN_bn2bin(n, buf.get());
On 2014/07/07 19:53:42, Ryan Sleevi wrote:
> nit: A bit of a code-smell to ignore a result. Though the implementation
always
> returns BN_num_bytes, it's not guaranteed by the API contract (just implied)

Done.

[mattm, 2014-07-07 21:32:58]

The CQ bit was checked by mattm@chromium.org

[commit-bot: I haz the power, 2014-07-07 21:34:56]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mattm@chromium.org/371953003/20001

[commit-bot: I haz the power, 2014-07-08 00:55:57]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)

[commit-bot: I haz the power, 2014-07-08 01:17:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-08 01:17:23]

Try jobs failed on following builders:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)

[mattm, 2014-07-10 01:36:23]

The CQ bit was checked by mattm@chromium.org

[commit-bot: I haz the power, 2014-07-10 01:38:39]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mattm@chromium.org/371953003/20001

[commit-bot: I haz the power, 2014-07-10 01:40:28]

Change committed as 282213