Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(469)

Issue 371943003: Set parcel data position to 0 when cloning the relro bundle. (Closed)

Created:
6 years, 5 months ago by simonb (inactive)
Modified:
6 years, 5 months ago
Reviewers:
rmcilroy
CC:
chromium-reviews, erikwright+watch_chromium.org, Andrew Hayden (chromium.org), pasko
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Set parcel data position to 0 when cloning the relro bundle. Rename local variable from 'p' to 'parcel. Call parcel.setDataPosition(0) between write and read. Fix a log message for punctuation. Fixes (from logcat): E/Bundle ( 5115): readBundle: bad magic number E/Bundle ( 5115): readBundle: trace = java.lang.RuntimeException E/Bundle ( 5115): at android.os.Bundle.readFromParcelInner(Bundle.java:1677) E/Bundle ( 5115): at android.os.Bundle.readFromParcel(Bundle.java:1670) E/Bundle ( 5115): at org.chromium.base.library_loader.Linker.useSharedRelros(Linker.java:494) E/Bundle ( 5115): at org.chromium.content.app.ChildProcessService$1.setupConnection(ChildProcessService.java:100) E/Bundle ( 5115): at org.chromium.content.common.IChildProcessService$Stub.onTransact(IChildProcessService.java:57) E/Bundle ( 5115): at android.os.Binder.execTransact(Binder.java:388) E/Bundle ( 5115): at dalvik.system.NativeStart.run(Native Method) BUG=388356 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282298

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M base/android/java/src/org/chromium/base/library_loader/Linker.java View 1 chunk +6 lines, -5 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
simonb (inactive)
6 years, 5 months ago (2014-07-07 16:00:05 UTC) #1
rmcilroy
lgtm, thanks.
6 years, 5 months ago (2014-07-07 16:23:13 UTC) #2
simonb (inactive)
The CQ bit was checked by simonb@chromium.org
6 years, 5 months ago (2014-07-07 16:53:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/simonb@chromium.org/371943003/1
6 years, 5 months ago (2014-07-07 16:55:14 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 5 months ago (2014-07-07 20:36:50 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-07 20:46:33 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/168560)
6 years, 5 months ago (2014-07-07 20:46:34 UTC) #7
simonb (inactive)
The CQ bit was checked by simonb@chromium.org
6 years, 5 months ago (2014-07-08 12:36:36 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/simonb@chromium.org/371943003/1
6 years, 5 months ago (2014-07-08 12:37:16 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 5 months ago (2014-07-08 14:06:03 UTC) #10
simonb (inactive)
The CQ bit was unchecked by simonb@chromium.org
6 years, 5 months ago (2014-07-08 15:42:53 UTC) #11
simonb (inactive)
The CQ bit was checked by simonb@chromium.org
6 years, 5 months ago (2014-07-10 08:01:55 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/simonb@chromium.org/371943003/1
6 years, 5 months ago (2014-07-10 08:02:30 UTC) #13
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 5 months ago (2014-07-10 09:14:54 UTC) #14
commit-bot: I haz the power
6 years, 5 months ago (2014-07-10 10:55:45 UTC) #15
Message was sent while issue was closed.
Change committed as 282298

Powered by Google App Engine
This is Rietveld 408576698