Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Unified Diff: chrome/browser/content_settings/permission_bubble_request_impl.cc

Issue 371933002: Add UMA for the new generic permisison class (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/content_settings/permission_bubble_request_impl.cc
diff --git a/chrome/browser/content_settings/permission_bubble_request_impl.cc b/chrome/browser/content_settings/permission_bubble_request_impl.cc
index 3767de224fc4decfd91b4e4458a22b0b2f448c1e..b7341db6185730c6356737728f64caf66c4189cd 100644
--- a/chrome/browser/content_settings/permission_bubble_request_impl.cc
+++ b/chrome/browser/content_settings/permission_bubble_request_impl.cc
@@ -5,6 +5,7 @@
#include "chrome/browser/content_settings/permission_bubble_request_impl.h"
#include "chrome/browser/content_settings/permission_context_base.h"
+#include "chrome/browser/content_settings/permission_context_uma_util.h"
#include "grit/generated_resources.h"
#include "grit/theme_resources.h"
#include "net/base/net_util.h"
@@ -23,11 +24,14 @@ PermissionBubbleRequestImpl::PermissionBubbleRequestImpl(
display_languages_(display_languages),
permission_decided_callback_(permission_decided_callback),
delete_callback_(delete_callback),
- is_finished_(false) {
+ is_finished_(false),
+ action_taken_(false) {
}
PermissionBubbleRequestImpl::~PermissionBubbleRequestImpl() {
DCHECK(is_finished_);
+ if (!action_taken_)
+ PermissionContextUmaUtil::PermissionIgnored(type_);
}
int PermissionBubbleRequestImpl::GetIconID() const {
@@ -92,14 +96,17 @@ GURL PermissionBubbleRequestImpl::GetRequestingHostname() const {
}
void PermissionBubbleRequestImpl::PermissionGranted() {
+ RegisterActionTaken();
permission_decided_callback_.Run(true, true);
}
void PermissionBubbleRequestImpl::PermissionDenied() {
+ RegisterActionTaken();
permission_decided_callback_.Run(true, false);
}
void PermissionBubbleRequestImpl::Cancelled() {
+ RegisterActionTaken();
permission_decided_callback_.Run(false, false);
}

Powered by Google App Engine
This is Rietveld 408576698