Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(859)

Unified Diff: chrome/browser/content_settings/content_settings_default_provider.cc

Issue 371933002: Add UMA for the new generic permisison class (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/content_settings/permission_bubble_request_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/content_settings/content_settings_default_provider.cc
diff --git a/chrome/browser/content_settings/content_settings_default_provider.cc b/chrome/browser/content_settings/content_settings_default_provider.cc
index 8673960f130427c0fe0d65481cb5e8e3ada120cb..c64a076be9bce303326dfa83647980203d92141d 100644
--- a/chrome/browser/content_settings/content_settings_default_provider.cc
+++ b/chrome/browser/content_settings/content_settings_default_provider.cc
@@ -169,8 +169,11 @@ DefaultProvider::DefaultProvider(PrefService* prefs, bool incognito)
ValueToContentSetting(
default_settings_[CONTENT_SETTINGS_TYPE_MIDI_SYSEX].get()),
CONTENT_SETTING_NUM_SETTINGS);
-
- // TODO(miguelg): Add UMA for Push messaging here
+ UMA_HISTOGRAM_ENUMERATION(
+ "ContentSettings.DefaultPushMessagingSetting",
+ ValueToContentSetting(
+ default_settings_[CONTENT_SETTINGS_TYPE_PUSH_MESSAGING].get()),
+ CONTENT_SETTING_NUM_SETTINGS);
pref_change_registrar_.Init(prefs_);
PrefChangeRegistrar::NamedChangeCallback callback = base::Bind(
« no previous file with comments | « no previous file | chrome/browser/content_settings/permission_bubble_request_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698