chrome/browser/content_settings/permission_context_uma_util.h - Issue 371933002: Add UMA for the new generic permisison class

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/content_settings/permission_context_uma_util.h

Issue 371933002: Add UMA for the new generic permisison class (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2014 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_CONTENT_SETTINGS_PERMISSION_CONTEXT_UMA_UTIL_H_

	6 #define CHROME_BROWSER_CONTENT_SETTINGS_PERMISSION_CONTEXT_UMA_UTIL_H_

	7

	8 #include "base/logging.h"

	9 #include "chrome/common/content_settings_types.h"

	10

	11 // Provides a convenient way of logging UMA for permission related

	12 // operations.

	13 class PermissionContextUmaUtil {

	14 public:

	15 static void PermissionGranted(ContentSettingsType permission);

	16 static void PermissionDenied(ContentSettingsType permission);

	17 static void PermissionDismissed(ContentSettingsType permission);

	18 static void PermissionIgnored(ContentSettingsType permission);

	19

	20
	Mark P 2014/07/15 20:17:41 nit: why the extra space? Did you intend to have nit: why the extra space? Did you intend to have a label (private: ?) or comment here? Miguel Garcia 2014/07/16 11:15:27 Not really, it was an artifact of the refactor. Show quoted text On 2014/07/15 20:17:41, Mark P wrote: > nit: why the extra space? Did you intend to have a label (private: ?) or > comment here? Not really, it was an artifact of the refactor.
	21 static void PermissionRequested(ContentSettingsType permission);

	22

	23 private:

	24 DISALLOW_IMPLICIT_CONSTRUCTORS(PermissionContextUmaUtil);

	25 };

	26

	27 #endif // CHROME_BROWSER_CONTENT_SETTINGS_PERMISSION_CONTEXT_UMA_UTIL_H_

OLD	NEW