Issue 371913002: Revert "Only create arguments-maps in the bootstrapper, remove now obsolete ValueType flag."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 371913002: Revert "Only create arguments-maps in the bootstrapper, remove now obsolete ValueType flag." (Closed)

Created:
6 years, 5 months ago by Dmitry Lomov (no reviews)

Modified:
6 years, 5 months ago

Reviewers:
Toon Verwaest

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Revert "Only create arguments-maps in the bootstrapper, remove now obsolete ValueType flag." This reverts commit r22240 for breaking tests on Linux. Revert "Remove SetOwnPropertyIgnoreAttribute uses from the bootstrapper" This reverts commit r22241 for breaking tests on Linux. TBR=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22242

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+472 lines, -331 lines)			Patch
M	src/arm/code-stubs-arm.cc	View	3 chunks	+14 lines, -18 lines	0 comments	Download
M	src/arm64/code-stubs-arm64.cc	View	2 chunks	+29 lines, -29 lines	0 comments	Download
M	src/bootstrapper.cc	View	6 chunks	+133 lines, -76 lines	0 comments	Download
M	src/builtins.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/contexts.h	View	3 chunks	+120 lines, -111 lines	0 comments	Download
M	src/factory.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/factory.cc	View	2 chunks	+4 lines, -18 lines	0 comments	Download
M	src/heap.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/heap.cc	View	1 chunk	+52 lines, -0 lines	0 comments	Download
M	src/ia32/code-stubs-ia32.cc	View	3 chunks	+24 lines, -29 lines	0 comments	Download
M	src/objects.h	View	6 chunks	+18 lines, -2 lines	0 comments	Download
M	src/objects.cc	View	14 chunks	+31 lines, -18 lines	0 comments	Download
M	src/runtime.cc	View	8 chunks	+18 lines, -9 lines	0 comments	Download
M	src/x64/code-stubs-x64.cc	View	2 chunks	+20 lines, -18 lines	0 comments	Download
M	test/cctest/cctest.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	test/cctest/test-alloc.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Dmitry Lomov (no reviews)

6 years, 5 months ago (2014-07-07 13:12:45 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r22242 (tree was closed).

Expand Messages | Collapse Messages