Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Unified Diff: gpu/command_buffer/common/BUILD.gn

Issue 371903003: Add missing files/deps/defines (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gpu/command_buffer/common/BUILD.gn
diff --git a/gpu/command_buffer/common/BUILD.gn b/gpu/command_buffer/common/BUILD.gn
index 43b19402bcaf2ebe77e464d9041b8af6d353ac0d..865031db702df1ac1e98464c6253a5dfd6a5e77c 100644
--- a/gpu/command_buffer/common/BUILD.gn
+++ b/gpu/command_buffer/common/BUILD.gn
@@ -3,6 +3,7 @@
# found in the LICENSE file.
source_set("common") {
+ defines = [ "GPU_IMPLEMENTATION" ]
brettw 2014/07/08 21:58:33 After sources, before deps.
sources = [
"bitfield_helpers.h",
"buffer.cc",
@@ -21,9 +22,6 @@ source_set("common") {
"gles2_cmd_format_autogen.h",
"gles2_cmd_ids.h",
"gles2_cmd_ids_autogen.h",
- "gles2_cmd_utils.cc",
- "gles2_cmd_utils.h",
- "gles2_utils_export.h",
"id_allocator.cc",
"id_allocator.h",
"mailbox.cc",
@@ -34,9 +32,24 @@ source_set("common") {
"time.h",
]
- all_dependent_configs = [ "//third_party/khronos:khronos_headers" ]
+ deps = [
+ "//base",
+ ":gles2_utils",
brettw 2014/07/08 21:58:33 Put this above "//base" (local ones go first)
+ ]
+}
+
+component("gles2_utils") {
+ defines = [ "GLES2_UTILS_IMPLEMENTATION" ]
brettw 2014/07/08 21:58:33 After sources, before deps.
+
+ sources = [
+ "gles2_cmd_utils.cc",
+ "gles2_cmd_utils.h",
+ "gles2_utils_export.h",
+ ]
deps = [
"//base",
]
+
+ all_dependent_configs = [ "//third_party/khronos:khronos_headers" ]
}

Powered by Google App Engine
This is Rietveld 408576698