Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 371903003: Add missing files/deps/defines (Closed)

Created:
6 years, 5 months ago by cjhopman
Modified:
6 years, 5 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, tdresser+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, piman+watch_chromium.org, cc-bugs_chromium.org, erikwright+watch_chromium.org, ben+mojo_chromium.org, darin (slow to review)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Total comments: 6

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -4 lines) Patch
M base/BUILD.gn View 1 2 2 chunks +3 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/BUILD.gn View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
M gpu/command_buffer/common/BUILD.gn View 1 2 2 chunks +18 lines, -4 lines 0 comments Download
M gpu/command_buffer/service/BUILD.gn View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M gpu/config/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M gpu/ipc/BUILD.gn View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M mojo/public/cpp/bindings/BUILD.gn View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M skia/BUILD.gn View 1 2 3 chunks +18 lines, -0 lines 0 comments Download
M ui/accessibility/BUILD.gn View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M ui/events/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
cjhopman
brettw: *
6 years, 5 months ago (2014-07-07 22:47:13 UTC) #1
brettw
lgtm Just some reordering https://codereview.chromium.org/371903003/diff/40001/gpu/command_buffer/client/BUILD.gn File gpu/command_buffer/client/BUILD.gn (right): https://codereview.chromium.org/371903003/diff/40001/gpu/command_buffer/client/BUILD.gn#newcode35 gpu/command_buffer/client/BUILD.gn:35: defines = [ "GLES2_IMPL_IMPLEMENTATION" ] ...
6 years, 5 months ago (2014-07-08 21:58:33 UTC) #2
cjhopman
The CQ bit was checked by cjhopman@chromium.org
6 years, 5 months ago (2014-07-11 22:51:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cjhopman@chromium.org/371903003/60001
6 years, 5 months ago (2014-07-11 22:53:25 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg on tryserver.chromium ...
6 years, 5 months ago (2014-07-12 00:37:43 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-12 00:41:01 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/79557)
6 years, 5 months ago (2014-07-12 00:41:02 UTC) #7
cjhopman
TBR: darin@ for OWNERS of base/ gpu/ mojo/ skia/ ui/
6 years, 5 months ago (2014-07-12 01:16:16 UTC) #8
cjhopman
The CQ bit was checked by cjhopman@chromium.org
6 years, 5 months ago (2014-07-12 01:16:21 UTC) #9
cjhopman
The CQ bit was unchecked by cjhopman@chromium.org
6 years, 5 months ago (2014-07-12 01:16:47 UTC) #10
cjhopman
The CQ bit was checked by cjhopman@chromium.org
6 years, 5 months ago (2014-07-12 01:16:49 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cjhopman@chromium.org/371903003/60001
6 years, 5 months ago (2014-07-12 01:17:32 UTC) #12
commit-bot: I haz the power
6 years, 5 months ago (2014-07-12 04:59:26 UTC) #13
Message was sent while issue was closed. 
Change committed as 282804

Powered by Google App Engine
This is Rietveld 408576698