Issue 371853005: Move threadpool code from include/utils to tools/threadpool.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 371853005: Move threadpool code from include/utils to tools/threadpool. (Closed)

Created:
6 years, 5 months ago by mtklein_C

Modified:
6 years, 5 months ago

Reviewers:
henrik.smiding, mtklein, reed1

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

More Reviews

Description

Move threadpool code from include/utils to tools/threadpool. - Strips Sk- prefix from the code: this is not meant to be part of Skia library - Folds in checks from https://codereview.chromium.org/361423003/ BUG=skia:

Patch Set 1 #

Patch Set 2 : TRunnable too #

Patch Set 3 : gyp #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+120 lines, -495 lines)			Patch
M	dm/DMQuiltTask.cpp	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	dm/DMTask.h	View	1	3 chunks	+3 lines, -3 lines	0 comments	Download
M	dm/DMTaskRunner.h	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	gyp/dm.gyp	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	gyp/pathops_unittest.gyp	View		1 chunk	+4 lines, -1 line	0 comments	Download
M	gyp/public_headers.gypi	View	1 2	1 chunk	+0 lines, -12 lines	0 comments	Download
M	gyp/tests.gyp	View		1 chunk	+4 lines, -1 line	0 comments	Download
M	gyp/tools.gyp	View		2 chunks	+14 lines, -0 lines	0 comments	Download
M	gyp/utils.gypi	View		1 chunk	+0 lines, -6 lines	0 comments	Download
D	include/utils/SkCondVar.h	View		1 chunk	+0 lines, -68 lines	0 comments	Download
D	include/utils/SkRunnable.h	View		1 chunk	+0 lines, -25 lines	0 comments	Download
D	include/utils/SkThreadPool.h	View		1 chunk	+0 lines, -221 lines	0 comments	Download
D	src/utils/SkCondVar.cpp	View		1 chunk	+0 lines, -68 lines	0 comments	Download
M	tests/OnceTest.cpp	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	tests/PathOpsExtendedTest.cpp	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	tests/PathOpsSkpClipTest.cpp	View		6 chunks	+6 lines, -6 lines	0 comments	Download
M	tests/PathOpsThreadedCommon.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	tests/PathOpsThreadedCommon.cpp	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	tests/SkpSkGrTest.cpp	View		3 chunks	+4 lines, -4 lines	0 comments	Download
M	tests/skia_test.cpp	View		4 chunks	+4 lines, -4 lines	0 comments	Download
M	tools/skpdiff/SkDiffContext.cpp	View		5 chunks	+6 lines, -6 lines	0 comments	Download
A +	tools/threadpool/CondVar.h	View		2 chunks	+11 lines, -7 lines	0 comments	Download
A +	tools/threadpool/CondVar.cpp	View		7 chunks	+8 lines, -8 lines	0 comments	Download
A +	tools/threadpool/Runnable.h	View	1	1 chunk	+7 lines, -7 lines	0 comments	Download
A +	tools/threadpool/ThreadPool.h	View	1	8 chunks	+33 lines, -33 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages