Source/core/html/HTMLIFrameElement.idl - Issue 371833004: Use [TreatNullAs=EmptyString] for DOMString attributes with [Reflect]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLIFrameElement.idl

Issue 371833004: Use [TreatNullAs=EmptyString] for DOMString attributes with [Reflect] (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: the fix Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/HTMLIFrameElement.idl

diff --git a/Source/core/html/HTMLIFrameElement.idl b/Source/core/html/HTMLIFrameElement.idl

index 450b337a65da4b5c611db6b2fcc458b52dfb8d45..35c4d8c6a9b08d6497c7997403e4c15c946754b8 100644

--- a/Source/core/html/HTMLIFrameElement.idl

+++ b/Source/core/html/HTMLIFrameElement.idl

@@ -23,8 +23,8 @@ interface HTMLIFrameElement : HTMLElement {

[Reflect] attribute DOMString frameBorder;

[Reflect] attribute DOMString height;

[Reflect, URL] attribute DOMString longDesc;

- [Reflect, TreatNullAs=NullString] attribute DOMString marginHeight;

- [Reflect, TreatNullAs=NullString] attribute DOMString marginWidth;

+ [Reflect, TreatNullAs=EmptyString] attribute DOMString marginHeight;

+ [Reflect, TreatNullAs=EmptyString] attribute DOMString marginWidth;

[Reflect] attribute DOMString name;

[Reflect, TreatNullAs=NullString] attribute DOMString sandbox;

[Reflect] attribute DOMString scrolling;

« no previous file with comments | « Source/core/html/HTMLFrameElement.idl ('k') | Source/core/html/HTMLImageElement.idl » ('j') | no next file with comments »