tools/telemetry/telemetry/core/platform/profiler/tcmalloc_heap_profiler.py - Issue 371813005: [Android] Switch to DeviceUtils versions of Ls, SetJavaAsserts, GetProp, and SetProp.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/platform/profiler/tcmalloc_heap_profiler.py

Issue 371813005: [Android] Switch to DeviceUtils versions of Ls, SetJavaAsserts, GetProp, and SetProp. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/telemetry/telemetry/core/platform/profiler/tcmalloc_heap_profiler.py

diff --git a/tools/telemetry/telemetry/core/platform/profiler/tcmalloc_heap_profiler.py b/tools/telemetry/telemetry/core/platform/profiler/tcmalloc_heap_profiler.py

index 35043f7d17f48895343a59cff84b1354c5ad1474..3bbe6bf823fea02ea4f64a7c62e8649e2215e2b9 100644

--- a/tools/telemetry/telemetry/core/platform/profiler/tcmalloc_heap_profiler.py

+++ b/tools/telemetry/telemetry/core/platform/profiler/tcmalloc_heap_profiler.py

@@ -36,9 +36,9 @@ class _TCMallocHeapProfilerAndroid(object):

# This profiler requires adb root to set properties.

self._browser_backend.adb.device().old_interface.EnableAdbRoot()

for values in properties.itervalues():

- device_property = self._browser_backend.adb.system_properties[values[0]]

+ device_property = self._browser_backend.adb.device().GetProp(values[0])

if not device_property or not device_property.strip():

- self._browser_backend.adb.system_properties[values[0]] = values[1]

+ self._browser_backend.adb.device().SetProp(values[0], values[1])

device_configured = True

if not self._browser_backend.adb.device().FileExists(

self._DEFAULT_DEVICE_DIR):

« no previous file with comments | « tools/telemetry/telemetry/core/platform/profiler/java_heap_profiler.py ('k') | no next file » | no next file with comments »