tools/telemetry/telemetry/core/platform/profiler/android_traceview_profiler.py - Issue 371813005: [Android] Switch to DeviceUtils versions of Ls, SetJavaAsserts, GetProp, and SetProp.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/platform/profiler/android_traceview_profiler.py

Issue 371813005: [Android] Switch to DeviceUtils versions of Ls, SetJavaAsserts, GetProp, and SetProp. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/core/platform/android_platform_backend_unittest.py ('k') | tools/telemetry/telemetry/core/platform/profiler/java_heap_profiler.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/core/platform/profiler/android_traceview_profiler.py

diff --git a/tools/telemetry/telemetry/core/platform/profiler/android_traceview_profiler.py b/tools/telemetry/telemetry/core/platform/profiler/android_traceview_profiler.py

index 995401dd7d8d3c9ba6badbbbd55e10049aba3b4e..95794c511661c8337c411bf1a1cd896976bd4612 100644

--- a/tools/telemetry/telemetry/core/platform/profiler/android_traceview_profiler.py

+++ b/tools/telemetry/telemetry/core/platform/profiler/android_traceview_profiler.py

@@ -61,6 +61,5 @@ class AndroidTraceviewProfiler(profiler.Profiler):

return output_files

def _FileSize(self, file_name):

- f = self._browser_backend.adb.device().old_interface.ListPathContents(

- file_name)

+ f = self._browser_backend.adb.device().Ls(file_name)

return f.get(os.path.basename(file_name), (0, ))[0]