Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Unified Diff: tools/telemetry/telemetry/core/backends/adb_commands.py

Issue 371813005: [Android] Switch to DeviceUtils versions of Ls, SetJavaAsserts, GetProp, and SetProp. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/core/backends/adb_commands.py
diff --git a/tools/telemetry/telemetry/core/backends/adb_commands.py b/tools/telemetry/telemetry/core/backends/adb_commands.py
index ffa307ef35f6741386d1e69ac2a5e1d97e3d87d2..9cc9d25282dc7d77af0a5201b08cb7235c687fe0 100644
--- a/tools/telemetry/telemetry/core/backends/adb_commands.py
+++ b/tools/telemetry/telemetry/core/backends/adb_commands.py
@@ -87,7 +87,7 @@ class AdbCommands(object):
self._device.Install(apk_path)
def IsUserBuild(self):
- return self._device.old_interface.GetBuildType() == 'user'
+ return self._device.GetProp('ro.build.type') == 'user'
def GetBuildTypeOfPath(path):
@@ -121,7 +121,7 @@ def SetupPrebuiltTools(adb):
if platform.GetHostPlatform().GetOSName() == 'linux':
host_tools.append('host_forwarder')
- has_device_prebuilt = adb.system_properties['ro.product.cpu.abi'].startswith(
+ has_device_prebuilt = adb.device().GetProp('ro.product.cpu.abi').startswith(
'armeabi')
if not has_device_prebuilt:
return all([support_binaries.FindLocallyBuiltPath(t) for t in device_tools])

Powered by Google App Engine
This is Rietveld 408576698