Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6168)

Unified Diff: chrome/installer/util/google_update_settings.h

Issue 371753002: Installer refactoring: using string16 instead of wstring for GoogleUpdateSettings. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Using the proper UTF16 conversion routines; variable renaming. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/installer/gcapi/gcapi.cc ('k') | chrome/installer/util/google_update_settings.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/util/google_update_settings.h
diff --git a/chrome/installer/util/google_update_settings.h b/chrome/installer/util/google_update_settings.h
index a2ff11db8e61b3b320c7d38324dc18bf6849d6c9..b7bf6125613e9c0e492566dd3be7474fc9d01b25 100644
--- a/chrome/installer/util/google_update_settings.h
+++ b/chrome/installer/util/google_update_settings.h
@@ -116,19 +116,19 @@ class GoogleUpdateSettings {
// Returns in |browser| the browser used to download chrome as recorded
// Google Update. Returns false if the information is not available.
- static bool GetBrowser(std::wstring* browser);
+ static bool GetBrowser(base::string16* browser);
// Returns in |language| the language selected by the user when downloading
// chrome. This information is collected by the web server used to download
// the chrome installer. Returns false if the information is not available.
- static bool GetLanguage(std::wstring* language);
+ static bool GetLanguage(base::string16* language);
// Returns in |brand| the RLZ brand code or distribution tag that has been
// assigned to a partner. Returns false if the information is not available.
//
// NOTE: This function is Windows only. If the code you are writing is not
// specifically for Windows, prefer calling google_brand::GetBrand().
- static bool GetBrand(std::wstring* brand);
+ static bool GetBrand(base::string16* brand);
// Returns in |brand| the RLZ reactivation brand code or distribution tag
// that has been assigned to a partner for reactivating a dormant chrome
@@ -137,19 +137,19 @@ class GoogleUpdateSettings {
// NOTE: This function is Windows only. If the code you are writing is not
// specifically for Windows, prefer calling
// google_brand::GetReactivationBrand().
- static bool GetReactivationBrand(std::wstring* brand);
+ static bool GetReactivationBrand(base::string16* brand);
// Returns in |client| the google_update client field, which is currently
// used to track experiments. Returns false if the entry does not exist.
- static bool GetClient(std::wstring* client);
+ static bool GetClient(base::string16* client);
// Sets the google_update client field. Unlike GetClient() this is set only
// for the current user. Returns false if the operation failed.
- static bool SetClient(const std::wstring& client);
+ static bool SetClient(const base::string16& client);
// Returns in 'client' the RLZ referral available for some distribution
// partners. This value does not exist for most chrome or chromium installs.
- static bool GetReferral(std::wstring* referral);
+ static bool GetReferral(base::string16* referral);
// Overwrites the current value of the referral with an empty string. Returns
// true if this operation succeeded.
@@ -192,7 +192,7 @@ class GoogleUpdateSettings {
static void UpdateInstallStatus(bool system_install,
installer::ArchiveType archive_type,
int install_return_code,
- const std::wstring& product_guid);
+ const base::string16& product_guid);
// This method updates the value for Google Update "ap" key for Chrome
// based on whether we are doing incremental install (or not) and whether
@@ -229,13 +229,13 @@ class GoogleUpdateSettings {
// Takes a |handle| to a registry key and writes |value| string into the
// specified |key|. See DuplicateGoogleUpdateSystemClientKey for details.
static bool WriteGoogleUpdateSystemClientKey(int handle,
- const std::wstring& key,
- const std::wstring& value);
+ const base::string16& key,
+ const base::string16& value);
// Returns the effective update policy for |app_guid| as dictated by
// Group Policy settings. |is_overridden|, if non-NULL, is populated with
// true if an app-specific policy override is in force, or false otherwise.
- static UpdatePolicy GetAppUpdatePolicy(const std::wstring& app_guid,
+ static UpdatePolicy GetAppUpdatePolicy(const base::string16& app_guid,
bool* is_overridden);
// Returns true if the app indicated by |app_guid| should be updated
« no previous file with comments | « chrome/installer/gcapi/gcapi.cc ('k') | chrome/installer/util/google_update_settings.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698