|
|
Created:
6 years, 5 months ago by jbroman Modified:
6 years, 5 months ago CC:
chromium-reviews Base URL:
svn://svn.chromium.org/chrome/trunk/src Project:
chromium Visibility:
Public. |
DescriptionGN: add missing dependencies of //components/dom_distiller.
BUG=367595
NOTRY=true
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282730
Patch Set 1 #Patch Set 2 : #
Messages
Total messages: 17 (0 generated)
reported by `gn check`
lgtm! I ran gn check locally and manually confirmed that the dependencies you are adding here are included by components/dom_distiller/core. So this is OK by me. Thanks,
The CQ bit was checked by jbroman@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbroman@chromium.org/371643002/1
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
On 2014/07/05 02:16:39, I haz the power (commit-bot) wrote: > Try jobs failed on following builders: > chromium_presubmit on tryserver.chromium > (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...) need lgtm from brettw to land
lgtm
The CQ bit was checked by jbroman@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbroman@chromium.org/371643002/1
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
The CQ bit was checked by jbroman@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbroman@chromium.org/371643002/20001
Message was sent while issue was closed.
Change committed as 282730 |