Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 371643002: GN: add missing dependencies of //components/dom_distiller. (Closed)

Created:
6 years, 5 months ago by jbroman
Modified:
6 years, 5 months ago
Reviewers:
tfarina, brettw
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

GN: add missing dependencies of //components/dom_distiller. BUG=367595 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282730

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M components/dom_distiller/core/BUILD.gn View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
jbroman
reported by `gn check`
6 years, 5 months ago (2014-07-04 19:42:10 UTC) #1
tfarina
lgtm! I ran gn check locally and manually confirmed that the dependencies you are adding ...
6 years, 5 months ago (2014-07-04 23:39:10 UTC) #2
jbroman
The CQ bit was checked by jbroman@chromium.org
6 years, 5 months ago (2014-07-05 01:30:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbroman@chromium.org/371643002/1
6 years, 5 months ago (2014-07-05 01:31:02 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium ...
6 years, 5 months ago (2014-07-05 02:14:02 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-05 02:16:38 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/78030)
6 years, 5 months ago (2014-07-05 02:16:39 UTC) #7
jbroman
On 2014/07/05 02:16:39, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
6 years, 5 months ago (2014-07-07 13:43:12 UTC) #8
brettw
lgtm
6 years, 5 months ago (2014-07-08 21:15:22 UTC) #9
jbroman
The CQ bit was checked by jbroman@chromium.org
6 years, 5 months ago (2014-07-08 21:39:19 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbroman@chromium.org/371643002/1
6 years, 5 months ago (2014-07-08 21:40:30 UTC) #11
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium ...
6 years, 5 months ago (2014-07-08 21:46:16 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-08 21:52:35 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/78637)
6 years, 5 months ago (2014-07-08 21:52:36 UTC) #14
jbroman
The CQ bit was checked by jbroman@chromium.org
6 years, 5 months ago (2014-07-11 23:21:20 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbroman@chromium.org/371643002/20001
6 years, 5 months ago (2014-07-11 23:23:06 UTC) #16
commit-bot: I haz the power
6 years, 5 months ago (2014-07-11 23:24:56 UTC) #17
Message was sent while issue was closed.
Change committed as 282730

Powered by Google App Engine
This is Rietveld 408576698