chrome/browser/ui/views/sync/one_click_signin_bubble_view.cc - Issue 371633002: LabelButton: cache the last computed preferred size

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/sync/one_click_signin_bubble_view.cc

Issue 371633002: LabelButton: cache the last computed preferred size (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/sync/one_click_signin_bubble_view.cc

diff --git a/chrome/browser/ui/views/sync/one_click_signin_bubble_view.cc b/chrome/browser/ui/views/sync/one_click_signin_bubble_view.cc

index d6127ac2fd38117e3c48395f72eb5d9eb090fe82..622ba314964de39d990df5c331a6fb838d2058b4 100644

--- a/chrome/browser/ui/views/sync/one_click_signin_bubble_view.cc

+++ b/chrome/browser/ui/views/sync/one_click_signin_bubble_view.cc

@@ -284,12 +284,12 @@ void OneClickSigninBubbleView::GetButtons(views::LabelButton** ok_button,

// The default size of the buttons is too large. To allow them to be smaller

// ignore the minimum default size.,

- (*ok_button)->set_min_size(gfx::Size());

+ (*ok_button)->SetMinSize(gfx::Size());

if (is_sync_dialog_) {

*undo_button = new views::LabelButton(this, base::string16());

(*undo_button)->SetStyle(views::Button::STYLE_BUTTON);

- (*undo_button)->set_min_size(gfx::Size());

+ (*undo_button)->SetMinSize(gfx::Size());

base::string16 undo_label =

l10n_util::GetStringUTF16(IDS_ONE_CLICK_SIGNIN_DIALOG_UNDO_BUTTON);