ui/views/controls/button/checkbox.cc - Issue 371633002: LabelButton: cache the last computed preferred size

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/controls/button/checkbox.cc

Issue 371633002: LabelButton: cache the last computed preferred size (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/views/controls/button/checkbox.cc

diff --git a/ui/views/controls/button/checkbox.cc b/ui/views/controls/button/checkbox.cc

index 22c5f88e2d6c6a61783212485a2873df25d34231..0c212c43ef98d14e412da9e20f2d90fab10fe24c 100644

--- a/ui/views/controls/button/checkbox.cc

+++ b/ui/views/controls/button/checkbox.cc

@@ -67,7 +67,7 @@ Checkbox::Checkbox(const base::string16& label)

// Limit the checkbox height to match the legacy appearance.

const gfx::Size preferred_size(LabelButton::GetPreferredSize());

- set_min_size(gfx::Size(0, preferred_size.height() + 4));

+ SetMinSize(gfx::Size(0, preferred_size.height() + 4));

}

Checkbox::~Checkbox() {