Source/platform/heap/HeapTest.cpp - Issue 371623002: [oilpan]: Make thread shutdown more robust.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/heap/HeapTest.cpp

Issue 371623002: [oilpan]: Make thread shutdown more robust. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: review feedback Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/platform/heap/HeapTest.cpp

diff --git a/Source/platform/heap/HeapTest.cpp b/Source/platform/heap/HeapTest.cpp

index 44a4285eab9c520004971e10849a8e8a74fe7537..a58a9434592feceff68f1f07bd95ee7b2f99f3ad 100644

--- a/Source/platform/heap/HeapTest.cpp

+++ b/Source/platform/heap/HeapTest.cpp

@@ -1697,8 +1697,8 @@ TEST(HeapTest, TypedHeapSanity)

// We use TraceCounter for allocating an object on the general heap.

Persistent<TraceCounter> generalHeapObject = TraceCounter::create();

Persistent<TestTypedHeapClass> typedHeapObject = TestTypedHeapClass::create();

- EXPECT_NE(pageHeaderAddress(reinterpret_cast<Address>(generalHeapObject.get())),

- pageHeaderAddress(reinterpret_cast<Address>(typedHeapObject.get())));

+ EXPECT_NE(pageHeaderFromObject(generalHeapObject.get()),

+ pageHeaderFromObject(typedHeapObject.get()));

}

TEST(HeapTest, NoAllocation)