Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(710)

Issue 371573003: gcc 4.7 workaround for __uint16_t (Closed)

Created:
6 years, 5 months ago by Mostyn Bramley-Moore
Modified:
6 years, 5 months ago
CC:
chromium-reviews, agl, jln+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

gcc 4.7 workaround for __uint16_t It seems that with my gcc 4.7 / eglibc 2.11 toolchain, sys/user.h uses __uint16_t without it necessarily being defined first. This can be worked around by simply including sys/types.h first. BUG=231000 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281504

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M sandbox/linux/seccomp-bpf/linux_seccomp.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Mostyn Bramley-Moore
@Ricky, jorgelo: PTAL at this small followup to https://codereview.chromium.org/278583005
6 years, 5 months ago (2014-07-04 11:50:43 UTC) #1
Jorge Lucangeli Obes
lgtm
6 years, 5 months ago (2014-07-07 02:37:13 UTC) #2
Mostyn Bramley-Moore
The CQ bit was checked by mostynb@opera.com
6 years, 5 months ago (2014-07-07 05:57:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mostynb@opera.com/371573003/1
6 years, 5 months ago (2014-07-07 05:57:46 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: ios_dbg_simulator on tryserver.chromium ...
6 years, 5 months ago (2014-07-07 07:47:53 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-07 07:50:04 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/builds/167686)
6 years, 5 months ago (2014-07-07 07:50:05 UTC) #7
Mostyn Bramley-Moore
The CQ bit was checked by mostynb@opera.com
6 years, 5 months ago (2014-07-07 07:51:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mostynb@opera.com/371573003/1
6 years, 5 months ago (2014-07-07 07:52:34 UTC) #9
commit-bot: I haz the power
6 years, 5 months ago (2014-07-07 08:20:24 UTC) #10
Message was sent while issue was closed.
Change committed as 281504

Powered by Google App Engine
This is Rietveld 408576698